Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] add test for #10374 #11232

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

kLabz
Copy link
Contributor

@kLabz kLabz commented May 18, 2023

Closes #10374

@kLabz kLabz force-pushed the fix/issue10374 branch from b5a6bc6 to b546c4d Compare May 18, 2023 09:34
@kLabz kLabz requested a review from Simn May 23, 2023 05:59
src/typing/typeloadModule.ml Outdated Show resolved Hide resolved
@Simn
Copy link
Member

Simn commented Feb 8, 2024

Do you know what the status here (and in #10374) is now?

@kLabz
Copy link
Contributor Author

kLabz commented Feb 8, 2024

As said on slack, we actually need to make it a bit more strict so this PR needs to be updated

@kLabz kLabz changed the title Explicitely disallow redefining module level fields [tests] add test for #10374 Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Context.defineModule on exists module with TDField not works
2 participants