Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes hxb's unbound type parameter warnings' position which was displayed as
(unknown)
in non-pretty message reporting modes. Not adding a test because those warnings should not happen so the test would start failing when we fix the underlying issue..The actual fix here is using
pmin = 0; pmax = 0
instead ofpmin = -1; pmax = -1
in hxb writer, but this PR also:file_pos
andfake_pos
functions to avoid{ null_pos with ... }
/ manual pos building with pmin/pmax = 0 / -1Before:
After:
I'm still not sure how to handle "fake positions" in non-pretty message reporting modes, but that's not a new issue and should be addressed separately. For reference, this is about this:
vs: