Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cpp] Fix abstract class functions with default values #11667

Merged
merged 1 commit into from
May 15, 2024
Merged

[cpp] Fix abstract class functions with default values #11667

merged 1 commit into from
May 15, 2024

Conversation

Aidan63
Copy link
Contributor

@Aidan63 Aidan63 commented May 11, 2024 •
edited
Loading

(Closes #11666) Don't always pass None into ctx_arg as thats the default value arg which we need to pull from Meta.Value for abstract class functions.

@Aidan63 Aidan63 changed the title (Closes #11666) Fix abstract class functions with default values [cpp] Fix abstract class functions with default values May 11, 2024
@skial skial mentioned this pull request May 14, 2024
Closed
1 task
@Simn Simn merged commit d9791f6 into HaxeFoundation:development May 15, 2024
52 checks passed
@Aidan63 Aidan63 deleted the cpp_default_abstract_funcs branch May 15, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cpp] Abstract class functions with default values are broken
2 participants
@Aidan63 @Simn