[macro] don't add modules as dependencies when using Compiler.include #11701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kLabz
commented
Jun 21, 2024
•
kLabz
commented
- TODO: Trying to properly isolate the issue to add a server test
Simn
reviewed
Jun 21, 2024
src/core/tType.ml
Outdated
| @@ -406,6 +406,7 @@ and module_dep_origin = | |||
| | MDepFromTyping | |||
| | MDepFromImport | |||
| | MDepFromMacro | |||
| | MDepIgnore | |||
There was a problem hiding this comment.
Hmm, an "ignore" isn't really an origin. The design would be better if we had let ignore_dep_origin = function | MDepWhatever -> ... and then use a sensible origin everywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.