Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apple Silicon (arm64) build support #1361

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nheagy
Copy link

@nheagy nheagy commented Jan 4, 2025

This is a base set of changes to allow the project to be build for arm64, for Apple Silicon (M1, M2, etc).

  • Runs locally on my M1 macbook
  • Builds for release as universal

@fmoraes74
Copy link
Contributor

No idea why that is happening. Seems like an issue with property bindings. But I think the proper solution would be to try to make an universal app and that will require using the command line tooling to do the same for the Mono libcoreclr.dylib

@fmoraes74
Copy link
Contributor

@nheagy Do you have a CLA in place already? If not, @beheh can help with that

@beheh
Copy link
Contributor

beheh commented Jan 20, 2025

Hi there, thanks for your PR! All contributions to HearthSim require a signed CLA. I've sent you an invite to the repository, please follow the instructions there. If you've already signed the CLA, please let us know.

Once that's done and the CLA has been merged, we'll try to get this merged here as soon as possible.

@beheh
Copy link
Contributor

beheh commented Jan 28, 2025

Thanks for signing the CLA!

@fmoraes74 You can proceed here :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants