Unholy: Primary - Death Coil Auto Pop

[DrWren]

Before You Begin

• I confirm that I have downloaded the latest version of the addon.
• I am not playing on a private server.
• I checked for an existing, open ticket for this issue and was not able to find one.
• I edited the title of this bug report (above) so that it describes the issue I am reporting.

Describe the Issue

Doing m+ and it auto snapped.

How to Reproduce

Do mythic and just auto popped.

Player Information (Link)

https://pastebin.com/9cvykm42

Error Messages (Link)

https://pastebin.com/9cvykm42

Additional Information

Just helping

Contact Information

Wren1740

[syrifgit]

Looks like maybe it's trying to wait for the next rune to regen even though you already have enough? Will keep looking at it. If you have the screenshot that it took, please share it.

        55.  wound_spender ( cleave - 5 )
        The action (wound_spender) is usable at (1.00 + 1.08) with cost of 1 runes (have 4).
         - the action is ready before the current recommendation (at +1.08 vs. +10.00).
        List ( cleave ) called from ( Unholy:default:26 ) would PASS at 1.08.
        active_enemies[2.00] = 2
         - this entry's criteria FAILS: variable.pop_wounds[false]
        There are 1 recheck events.
        Times: 3.594804311695
        List ( cleave ) called from ( Unholy:default:26 ) would PASS at 4.67.
        active_enemies[2.00] = 2
        Recheck #1 ( +4.67 ) NOT MET: variable.pop_wounds[false]
        Time spent on this action:  0.18ms
        TimeData:Unholy-cleave-5:wound_spender:x1:0.18:Ability Known, Enabled(0.04):Post-TTR and Essential(0.05):Post Cycle(0.00):Post Usable(0.00):Post Ready/Clash(0.01):Post Stack(0.01):Pre-Script(0.00):Post-Script(0.00):Pre-Recheck(0.01):Post-Recheck Times(0.02):Pre-Recheck Loop(0.00):Recheck Loop Start(0.00):Recheck Post-Usable(0.01):Recheck Post-Stack(0.01):Recheck Post-Script(0.00):Recheck Post-Channel(0.00):Recheck Loop End(0.01):Post Recheck Loop(0.00):Post Recheck(0.00)
        Exiting cleave with recommendation of NO ACTION at +10.00s.
        Returned from list (cleave), current recommendation is NO ACTION (+10.00).
        - cleave
 

[bjth]

Another pastebin: https://pastebin.com/VufkY5Uq

Slightly different I think, but @syrifgit asked me to add it in here.

[bjth]

One screenshots as requested:

[DrWren]

[DrWren]

[DrWren]

[DrWren]

[DrWren]

Here are some of the screens shots. Here is another paste bin

https://pastebin.com/ukgHSQf3

[syrifgit]

With the screenshots I definitely think it's the rune thing we talked about @bjth. Do you want to PR that change you made using the FDK rune stuff?

[bjth]

Sure, I got Wren to try it with the updated class file and he was still getting pops.

I'll get a PR up later today either way.

[DrWren]

Glad I can be the test subject for you. It makes me feel a part of something important:-)

[Hekili]

The underlying issue here is the strict forking for AOE burst and regular AOE. When DND is wearing off, you can have enough remaining time to check the AOE burst list, but not enough time to actually select an ability from that list.

There is also some nuance with Death and Decay itself ticking vs. having the buff from standing in DND.

I am testing some changes to address these.

[DrWren]

Awesome, I can't wait to see what awesomeness comes along. Thanks you guys