Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4264 - Unholy: Primary - Death Coil Auto Pop (Align Runes + RP with Frost #4283

Open
wants to merge 2 commits into
base: thewarwithin
Choose a base branch
from
Open

#4264 - Unholy: Primary - Death Coil Auto Pop (Align Runes + RP with Frost #4283

wants to merge 2 commits into from

Conversation

bjth
Copy link
Contributor

@bjth bjth commented Jan 7, 2025 •
edited
Loading

Update UH Rune and RP simulation to align with Frost

@syrifgit
Copy link
Collaborator

syrifgit commented Jan 9, 2025 •
edited
Loading

Will test this soon. I was able to bork it most easily using m+ build at the 2-target cleave dummies (before this change).

@syrifgit
Copy link
Collaborator

syrifgit commented Jan 10, 2025 •
edited
Loading

This definitely seems to have fixed it. I can basically turn AoE autosnapshots on and off by reloading between current addon and this PR. Good catch.

Fixes: #4264

Good to go @Hekili

@syrifgit syrifgit requested a review from Hekili January 10, 2025 18:01
@syrifgit syrifgit added retail 🔝 escalated This ticket has been reviewed and requires Hekili's personal attention. labels Jan 10, 2025
@syrifgit syrifgit linked an issue Jan 16, 2025 that may be closed by this pull request
Unholy: Primary - Death Coil Auto Pop #4264
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hekili Hekili Awaiting requested review from Hekili

Assignees
No one assigned
Labels
🔝 escalated This ticket has been reviewed and requires Hekili's personal attention. retail
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unholy: Primary - Death Coil Auto Pop
2 participants
@bjth @syrifgit