Dials input files for regroup #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed else statement to an if of two bools
clarify default usage of the `-ef` flag
dennisbrookner
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
This looks great to me! Both I and @maggie-klureza have tested this new code and it works as expected. I think that the documentation changes are appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds support for reading in DIALS
exptfiles instead of Precognitioninpfiles. It includes adialsgeometry.pywith utility functions to support the needed information inregroup.py. The DIALS experiment list is directly available if further info is needed -- I only added functions for the data needed by the mainregroupfunction.The
READMEand__init__files are also adjusted.Notably these are not yet tested to ensure that the conventions don't differ. @dennisbrookner is testing on a dataset for which we have both DIALS and Precognition files to ensure output is identical.
If testing goes well then the PR should allow users to run on DIALS files directly without intermediate processing. Notably this PR only includes code applicable to DIALS stills files -- scans will error out with a useful error message. Future work can extend this to scans if needed, but there will be more bookkeeping involved.