fix: handle no access to view analytics gracefully

HemmeligOrg · Feb 12, 2025 · 84e2f22 · 84e2f22
1 parent 56a7795
commit 84e2f22
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 1 deletion.
diff --git a/client/services/analytics.js → client/api/analytics.js b/client/services/analytics.js → client/api/analytics.js
@@ -24,6 +24,13 @@ const getAnalyticsData = async () => {
         });
 
         if (!response.ok) {
+            if (response.status === 403) {
+                return {
+                    statusCode: 403,
+                    error: response.statusText,
+                };
+            }
+
             throw new Error('Failed to fetch analytics data');
         }
 
@@ -44,6 +51,13 @@ const getStatistics = async () => {
         });
 
         if (!response.ok) {
+            if (response.status === 403) {
+                return {
+                    statusCode: 403,
+                    error: response.statusText,
+                };
+            }
+
             throw new Error('Failed to fetch analytics data');
         }
 

diff --git a/client/routes.jsx b/client/routes.jsx
@@ -104,7 +104,7 @@ const createAppRouter = () => {
                         element={<Analytics />}
                         loader={async () => {
                             const { getAnalyticsData, getStatistics } = await import(
-                                './services/analytics'
+                                './api/analytics'
                             );
 
                             return await Promise.all([getAnalyticsData(), getStatistics()]);

diff --git a/client/routes/account/analytics.jsx b/client/routes/account/analytics.jsx
@@ -9,11 +9,21 @@ import {
     XAxis,
     YAxis,
 } from 'recharts';
+import ErrorBox from '../../components/error-box';
 
 const Analytics = () => {
     const { t } = useTranslation();
     const [analyticsData, stats] = useLoaderData();
 
+    // Handle error cases
+    if (analyticsData?.statusCode === 403) {
+        return (
+            <div className="animate-fadeIn">
+                <ErrorBox message={analyticsData?.error} />
+            </div>
+        );
+    }
+
     // Process data for path visualization
     const pathCounts = analyticsData.reduce((acc, item) => {
         acc[item.path] = (acc[item.path] || 0) + 1;