Guillotine Cross Poisoning Weapon skill fixes #3219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilherme-gm
changed the title
- the 2nd rate check that happens for Oblivion Curse was wrong in battle.c and it is also already performed in status.c, thus, having it in battle.c was both doing a wrong behavior and also reducing the chance more than it should have - the duration reduction based on targets vit and luk is already done in status.c, having it also performed in battle.c makes it reduce twice the time - this affects both SC_POISONINGWEAPON and skills that uses the poison effect added by it: Venom Pressure and Poison Smoke
while other effects lasts for 5 minutes, Venom Bleed only lasts for 15 seconds
a message stating which poison was selected should be displayed after the player selects one
guilherme-gm
force-pushed
the
guillotine-poison-fix
branch
from
fb7d28e
to
bd81482
Compare
guilherme-gm
changed the title
guilherme-gm
commented
Jul 29, 2023
guilherme-gm
commented
Jul 29, 2023
MishimaHaruna
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Solves some issues with Guillotine Cross' Poisoning Weapon skill:
References:
Issues addressed:
None, I think. Bug was found by Lexi on discord