Implementation of Hercules Ultimate Storage System (HUSS)

[jasonch35]

Pull Request Prelude

• I have followed proper Hercules code styling.
• I have read and understood the contribution guidelines before making this PR.
• I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

• Implementation of the Hercules Ultimate Storage System
• Storages can now be created through a configuration file that describes their attributes.
• Integrated storage_constants (Constant) into the configuration so that it can be assigned dynamically
• Capacity is capped by MAX_STORAGE at config reading

Storage Configuration

{
        Id: (int)			Unique Identifier
        Name: (string)			Name of the storage sent to the client.
        Constant: (string)		Storage constant to be used by scripts
        Capacity: (int)			Maximum capacity of the storage.
}

Script Command
openstorage(<storage_constant>{, <storage_mode>});

Storage Modes

• STORAGE_ACCESS_VIEW: View storage only.
• STORAGE_ACCESS_GET: Allow retrieving items from storage.
• STORAGE_ACCESS_PUT: Allow depositing items into storage.
• STORAGE_ACCESS_ALL: (Default mode) Full access for viewing, retrieving, and depositing items.

All atcommands utilizing storage has been updated as well:

• @storage <storage name/id>
• @storeall <storage name/id>
• @clearstorage <storage name/id>
• @storagelist command only list Main storage for now

Issues addressed:

• Implementation of Hercules Ultimate Storage System (HUSS) #1763
• Hercules Ultimate Storage System #2724
• HUSS #3302

Credits to: @sagunkho and @dastgirp

Let's gooooo let's push this through!

[vBrenth]

Thank you @jasonch35 hope this one will get implemented.
Also i want to ask about Storage Limit its still 600 correct?

[jasonch35]

Thank you @jasonch35 hope this one will get implemented.
Also i want to ask about Storage Limit its still 600 correct?

Yes, Limit is capped by MAX_STORAGE which is 600 by default.

[jasonch35]

Btw, I kept the "default" storage without warning/errors as it is set as default in original Herc's branch.
Commands and scripts will result in "no storage found" message if it is removed/changed.
Or parameter error on server start if its constant isn't found.
I believe server owners should be responsible for adjusting the configuration file, just as they would if they manually remove Red_Potion in item_db.conf, they'd have to manually remove them in scripts if they choose to do so.