Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: content vs element #347

Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix: content vs element #347

merged 1 commit into from
Nov 20, 2024

Conversation

marrouchi
Copy link
Contributor

@marrouchi marrouchi commented Nov 19, 2024

Motivation

This PR fixes things about lists and carousel. We have now :

  1. Content (that is the object as stored in DB - with dynamicFields)
  2. ContentElement which is a flattened form of the content. It would be used in list / carousel ("elements" attribute)

This should solve the confusion around both, both in channel and plugins.

Type of change:

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@marrouchi marrouchi merged commit db13d02 into main Nov 20, 2024
5 checks passed
Copy link
Collaborator

@IkbelTalebHssan IkbelTalebHssan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix tested and approved 🚀 ✔️
Screenshot from 2024-11-20 11-45-56
Screenshot from 2024-11-20 11-45-04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants