Quant gen vignette #444
Merged
Quant gen vignette #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@janaobsteter please have a look at my changes in the criterion functions documentation - I was adding link to vignette and thought some polish was in order to have consistency across the package. |
janaobsteter
commented
Nov 14, 2022
…ill create another branch for this work.
|
@janaobsteter have a look if you are OK with the above two discussions and then we merge this in |
|
@janaobsteter have a look if you are OK with the above two discussions and then we merge this in - there is lots of action with vignettes so we will diverge ... |
(wanted to create a separate branch, but that will get very outdated quickly so pushing to devel and we work on it later - have put it in .Rbuildignore so we don't have issues with R CMD check and submission to CRAN)
|
@gregorgorjanc , I've replied to the comments |
|
OK, merging this in so we move to the next vignette! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.