New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SM Graveyard and SFK in vanilla #351

Closed

Ineverknow wants to merge 2 commits into Hoizame:development from Ineverknow:development

Ineverknow commented Mar 23, 2023 •

edited

Loading

This should fix issue #331.

Bosses added to vanilla dungeons in WotLK are nil in vanilla, causing the assertion in ItemDB:GetItemTable to trigger because there's no loot table.

Changes made:

Replaced assertion with an if statement, checks if there's a boss id and loot table.
Added a type check to make sure items is actually a table, for bosses that don't exist this is nil.

As I'm new to both this addon, WoW addon programming and Lua, I'd love some feedback and tips if you have any.

Ineverknow added 2 commits

March 23, 2023 17:51


          Fix SM Graveyard and SFK in vanilla

2330f9d


          Moved table check to for loops

7b6555f

Ineverknow closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet