Allow specifying custom code generation settings #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhrcek
changed the title
turboMaCk
approved these changes
Mar 24, 2023
|
Thanks, docs updated. |
turboMaCk
reviewed
Mar 25, 2023
|
Is anything blocking merge of this? |
|
We didn't get any feedback from @silky who actually requested that change. |
jhrcek
force-pushed
the
jan/configurable-field-label-modifier
branch
from
e24f404 to
0fdca95
Compare
jhrcek
force-pushed
the
jan/configurable-field-label-modifier
branch
from
0fdca95 to
8b79edc
Compare
|
Apologies for never getting around to responding to this; in the end I changed jobs since I needed it :) But at a glance, it definitely does what I wanted, and I'll probably have cause to use it again at some point in the future; so that's great! Thanks :) 🙏🏻 |
nitinprakash96
approved these changes
Aug 2, 2023
turboMaCk
reviewed
Aug 2, 2023
| Just (User {userName = "John", userAge = 42}) | ||
|
|
||
|
|
||
| >>> data VeryLongType = VeryLongType { vltName :: String, vltAge :: Int } deriving (Generic, Show) | ||
| >>> instance FromJSON VeryLongType where parseJSON = elmStreetParseJson | ||
| >>> decode @VeryLongType "{ \"name\": \"John\", \"age\": 42 }" | ||
| >>> decode @VeryLongType "{\"age\":42,\"name\":\"John\",\"tag\":\"VeryLongType\"}" |
There was a problem hiding this comment.
doesn't seem that long to me 👀 ProjectContractChargingPeriodProjectAccountReferenceVMFactoryBuilderStrategy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm playing with ways that would allow resolving #129
while keeping the old behavior (stripping type name prefix) by default.
The important thing is that generated Elm encoders and decoders have to be compatible with ToJSON / FromJSON instances of Haskell types used across Haskell + Elm. This means that both Elm instance and ToJSON / FromJSON must use the same (what I call)
CodeGenSettingsthat carry the "field label modifier" function (which for now is the only aspect of code generation that we allow to override).See Type.hs for an example of how this could be used.
I'll need to think if this could be done more nicely over the next few days, but feel free to provide feedback if any.