grafx 2.8.3174,71 #203523
grafx 2.8.3174,71 #203523
Conversation
There was a problem hiding this comment.
The existing livecheck block is working as expected but the regex doesn't match 2.8.3174 because the filename uses sdl instead of sdl2. It will match if we use sdl\d* instead but that will also surface some other versions that may or may not be appropriate. There are a bunch of different variants (e.g., sdl, sdl2, nottf, plist, etc.) and I'm not sure which are appropriate for the cask.
It may be best to simply rely on upstream to indicate which should be used for macOS. The cask homepage links to https://grafx2.eu/ as the "main website" and the download page on that site links to download 71 for macOS. We could check that page to get the download ID for macOS and then fetch the headers for the download and match the version from the filename in the Content-Disposition header. It takes two requests and matching the loose text on the download page may break if they tweak the text but it's potentially better than guessing whether a new version is appropriate to use. It also relies on upstream keeping the download page up to date but we can always revisit this if needed.
If that makes sense to you, I can push an updated livecheck block.
That's why I initially removed the
Sure, thanks! |
Upstream lists a number of files for macOS on the download page (https://pulkomandy.tk/projects/GrafX2/downloads) but it's not clear which variant we should use. The homepage links to grafx2.eu as the "Main website" and its download page links to a specific download for macOS, so this updates the `livecheck` block to check that. The full version isn't listed on the page, so we have to check the filename in the `Content-Disposition` header of the download response. This works for now but it's far from ideal, so we may have to revisit this if/when it breaks or returns an inappropriate version (i.e., the matching regex is fairly loose and may not work as expected if the upstream text format changes).
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.