-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dynamips 0.2.23 #119574
dynamips 0.2.23 #119574
Conversation
c431987
to
6efd290
Compare
Formula/dynamips.rb
Outdated
license "GPL-2.0" | ||
url "https://github.com/GNS3/dynamips/archive/v0.2.23.tar.gz" | ||
sha256 "503bbb52c03f91900ea8dbe8bd0b804b76e2e28d0b7242624e0d3c52dda441a1" | ||
license "GPL-2.0-or-later" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does it say this? I just created GNS3/dynamips#135 because it doesn't specify
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used this: https://github.com/GNS3/dynamips/blob/master/COPYING#L296-L299 mainly and also this: https://github.com/GNS3/dynamips/blob/master/COPYING#L242-L248
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the standard license text for the GPLv2 license
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't specify if later versions can be used though, it just says that upstream can specify if they want to allow that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad for being mistaken there, then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Porkepix Try this: https://tools.spdx.org/app/check_license/
@chenrui333 Showed it to me and I've been using it extensively.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license "GPL-2.0-or-later" |
In case upstream does not answer in the next hours, let's maybe just ship this without the license change. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a |
6efd290
to
28baa65
Compare
🤖 A scheduled task has triggered a merge. |
Created by
brew bump
Created with
brew bump-formula-pr
.