Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamips 0.2.23 #119574

Closed
wants to merge 1 commit into from
Closed

Conversation

Porkepix
Copy link
Contributor

@Porkepix Porkepix commented Jan 2, 2023

Created by brew bump


Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added bump-formula-pr PR was created using `brew bump-formula-pr` deprecated license Formula uses a deprecated SPDX license which should be updated labels Jan 2, 2023
@Porkepix Porkepix force-pushed the bump-dynamips-0.2.23 branch from c431987 to 6efd290 Compare January 2, 2023 11:15
@BrewTestBot BrewTestBot removed the deprecated license Formula uses a deprecated SPDX license which should be updated label Jan 2, 2023
license "GPL-2.0"
url "https://github.com/GNS3/dynamips/archive/v0.2.23.tar.gz"
sha256 "503bbb52c03f91900ea8dbe8bd0b804b76e2e28d0b7242624e0d3c52dda441a1"
license "GPL-2.0-or-later"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does it say this? I just created GNS3/dynamips#135 because it doesn't specify

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the standard license text for the GPLv2 license

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't specify if later versions can be used though, it just says that upstream can specify if they want to allow that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad for being mistaken there, then.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Porkepix Try this: https://tools.spdx.org/app/check_license/

@chenrui333 Showed it to me and I've been using it extensively.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
license "GPL-2.0-or-later"

@iMichka
Copy link
Member

iMichka commented Jan 2, 2023

In case upstream does not answer in the next hours, let's maybe just ship this without the license change.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Jan 7, 2023
@Porkepix Porkepix force-pushed the bump-dynamips-0.2.23 branch from 6efd290 to 28baa65 Compare January 7, 2023 12:00
@BrewTestBot BrewTestBot added the missing license Formula has a missing license which should be added label Jan 7, 2023
@github-actions github-actions bot removed the stale No recent activity label Jan 7, 2023
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@Porkepix Porkepix deleted the bump-dynamips-0.2.23 branch January 7, 2023 23:23
@github-actions github-actions bot added the outdated PR was locked due to age label Feb 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` missing license Formula has a missing license which should be added outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants