Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semgrep: fix shell completions #195857

Merged
1 commit merged into from
Oct 28, 2024
Merged

Conversation

kopecs
Copy link
Contributor

@kopecs kopecs commented Oct 28, 2024

Newer versions of semgrep default to a non-click based implementation if possible. This includes when it is run without any arguments. To ensure completions can be generated using click, we need to pass the --legacy flag.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Newer versions of semgrep default to a non-click based implementation if
possible. This includes when it is run without any arguments. To ensure
completions can be generated using click, we need to pass the `--legacy` flag.
@github-actions github-actions bot added ocaml OCaml use is a significant feature of the PR or issue python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue labels Oct 28, 2024
@kopecs
Copy link
Contributor Author

kopecs commented Oct 28, 2024

Sorry, this is slightly out of date. Force pushing to fix audit issues (line length/revision position), but my git takes exceedingly long to push to clones of this repo.

Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@kopecs kopecs force-pushed the semgrep/fix-completions branch from d0bd70d to 55e1e49 Compare October 28, 2024 20:03
carlocab
carlocab previously approved these changes Oct 28, 2024
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

⛔ It looks like @BrewTestBot cannot push to your PR branch. Please open future pull requests from a non-organization fork to simplify the merge process.

@github-actions github-actions bot added the no push access Maintainers cannot push to this pull request. label Oct 28, 2024
Copy link
Contributor

🤖 An automated task has requested creation of a replacement PR.

@github-actions github-actions bot dismissed carlocab’s stale review October 28, 2024 21:46

Replacement PR dispatched

@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request superseded PR was replaced by another PR labels Oct 28, 2024
@BrewTestBot BrewTestBot marked this pull request as draft October 28, 2024 21:48
Copy link
Contributor

✅ Replacement PR created at #195868.

@github-merge-queue github-merge-queue bot closed this pull request by merging all changes into Homebrew:master in 8c520db Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request no push access Maintainers cannot push to this pull request. ocaml OCaml use is a significant feature of the PR or issue python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue shell-completion superseded PR was replaced by another PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants