Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ntopng: reduce lua to build dependency #66152

Closed
wants to merge 1 commit into from
Closed

ntopng: reduce lua to build dependency #66152

wants to merge 1 commit into from

Conversation

gromgit
Copy link
Member

@gromgit gromgit commented Dec 3, 2020

Also add proper test.

Followup to #65993.

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

ntopng: reduce lua to build dependency
a00d1e0 
Also add proper test.

Followup to Homebrew#65993.
@BrewTestBot BrewTestBot added the lua Lua use is a significant feature of the PR or issue label Dec 3, 2020
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@gromgit gromgit deleted the ntopng_static_lua branch December 8, 2020 02:54
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 7, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SMillerDev SMillerDev SMillerDev approved these changes

Assignees
No one assigned
Labels
lua Lua use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gromgit @BrewTestBot @SMillerDev