{testdisk,flash}: Remove hdiutil-requiring tests #66311
Conversation
This test fails to run at least on Big Sur with hdiutil failing with a strange "Directory not empty" This seems to be a sideeffect of the sandboxing that "brew test" does and I can't find an easy way to repair it.
This test fails to run at least on Big Sur with hdiutil failing with a strange "Directory not empty" This seems to be a sideeffect of the sandboxing that "brew test" does and I can't find an easy way to repair it.
|
We won't be removing all tests, you'll need to find a different way to test the program. |
|
OK, so you'd rather keep tests that literally fail every time they run? Keep in mind that I am not the originator of these formulae; I am just trying to help out getting broken formulae building again so that we can fix some Big Sur bottling issues. These ones currently can't auto-bottle because |
This doesn't do that though, it hides a problem. We need some test that succeeds and shows that the compilation went okay, otherwise we're just blindly hoping that it succeeded. |
|
Agree with @SMillerDev completely, let's not remove tests, otherwise we're just blind. We already have too many formulas without tests. Regarding sandboxing, it's possible Xcode 12 introduced new or finer-grained permissions. Something similar happened with Xcode 11, I think, and we had to change the sandbox profile in |
|
I've created a brew PR to add a test.dmg to our fixtures: Homebrew/brew#9499 |
|
@mitchblank I've merged the dmg test fixtures PR in brew |
Per the discussion on Homebrew#66311, "hdiutil -create" no longer works inside of the testing sandbox; use the new gzip'ed disk image inside fixtures instead
Per the discussion on Homebrew#66311, "hdiutil -create" no longer works inside of the testing sandbox; use the new gzip'ed disk image inside fixtures instead
Per the discussion on #66311, "hdiutil -create" no longer works inside of the testing sandbox; use the new gzip'ed disk image inside fixtures instead
Per the discussion on #66311, "hdiutil -create" no longer works inside of the testing sandbox; use the new gzip'ed disk image inside fixtures instead
As I discussed more in #66304, tests requiring
hdiutilare failing, probably due to a sandbox limitation.For gptfdisk I had an easy workaround, but these two would be harder. Regrettably, I think the easiest thing is to just remove these tests since they never pass anymore.
This should also let
testdiskre-bottle for Big Sur correctly -- it's currently on the #65000 leaderboard of top-downloaded formulae with bottling issues