[email protected]: fix build without python 2

[mitchblank]

These are some of the same changes that @iMichka made in #50391 to the main subversion formula. Builds fine for me on Big Sur with this imported.

[iMichka]

We can't use Python 3 for this version of subversion. It will build be be unusable. So subversion 1.8 should stay with Python 2.

Python 3 support came with version 1.14, see #53193

[mitchblank]

@iMichka -- these changes are to the sconv files which are used to build subversion. Without them this formula doesn't build from source, hence why it never got rebottled for Big Sur (per #65000). That is all I'm trying to address.

So what is the best solution, just disabling this formula? Or is there a way to mark a formula that is no longer source-buildable but we want to keep around for its bottles?

[iMichka]

Nothing depends on it, and the download counts are really low. I would deprecate it with:
deprecate! date: "2020-12-21", because: :versioned_formula

[mitchblank]

I certainly don't care one way or the other about deprecation. I don't use subversion myself, much less an old version of it. I just took a look at it because it's on the Big Sur list and wanted to see what it would take to fix.

However, I still have my doubts about your statement that:

It will build be be unusable.

Do you know what the particular issue would be? Looking at the files that end up in /usr/local/opt/[email protected] post-install, none of them are python scripts. Also none of the binaries link against libpython*.dylib or anything like that. As far as I am aware subversion is basically all in C. (Unlike, say, mercurial which actually does rely on python at runtime)

My understanding is still that it just needs a python environment for building (scons, etc) so by backporting those build patches the generated program should just be OK I would think.

But, again, I'm not wedded to either option. If it's time for the formula to die, I don't care. I just want to see everything installable from source.

[iMichka]

The report we got back then was that python bindings got broken with Python 3: #53193

At this point I would let it die with:
deprecate! date: "2020-12-21", because: :versioned_formula

It has only 104 downloads per month so it's very low and not worth maintaining anymore.