libgcrypt 1.9.0

[J-M0]

Created with brew bump-formula-pr.

[carlocab]

Looks like this needs another patch? The original patch failed to apply, but now there's a build failure.

[J-M0]

Is embedding the patches like I did ok, or is there a way to download them from the mailing list?

[carlocab]

It's a small patch, so I guess embedding it is fine. Not sure there's a way to get the patches from the mailing list. I'd like to wait a little bit to see if that patch will get reviewed, especially given how security-sensitive libgcrypt is. Unless there is something important in this version bump that we don't want to delay?

[J-M0]

I'm not aware of any pressing reason to upgrade to 1.9 right away, so I think waiting is fine

[carlocab]

Great. Let's wait a little bit to see if the patch will be reviewed. I think the author of the patch is a libgcrpyt developer, so it probably should be fine even if it isn't.

[carlocab]

Judging from https://dev.gnupg.org/T5159 (see last comment), it looks like at least some of this

homebrew-core/Formula/libgcrypt.rb

Lines 43 to 52 in 9a60a0f

	on_macos do
	# Slightly hideous hack to help `make check` work in
	# normal place on >10.10 where SIP is enabled.
	# https://github.com/Homebrew/homebrew-core/pull/3004
	# https://bugs.gnupg.org/gnupg/issue2056
	MachO::Tools.change_install_name("#{buildpath}/tests/.libs/random",
	"#{lib}/libgcrypt.20.dylib",
	"#{buildpath}/src/.libs/libgcrypt.20.dylib")
	MachO.codesign!("#{buildpath}/tests/.libs/random") if Hardware::CPU.arm?
	end

can be removed?

[chenrui333]

try out hack removal commit.

[carlocab]

Exactly what I would've tried removing too. Thanks, @chenrui333.

[carlocab]

Should we keep a comment explaining why we still codesign on ARM? A link to an upstream report would be good for that too...

[carlocab]

Not sure why dar is failing on Big Sur. Can you try giving it a revision bump, @J-M0?

[carlocab]

Third time's not the charm, I guess:

Error: 1 failed step!
brew test --retry --verbose dar

[SeekingMeaning]

Oops, I should have checked #65000; dar is a known failure on Big Sur

[BrewTestBot]

@SeekingMeaning has triggered a merge.