-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
icu4c 68.2 #71274
icu4c 68.2 #71274
Conversation
On ARM: Error: 182 failed steps!
Big Sur: Error: 206 failed steps!
Catalina: Error: 206 failed steps!
Mojave: Error: 206 failed steps!
I suspect all the Intel failures are the same but haven't looked closely. I'm going to give all the linkage failures a rev bump. |
Linkage failures
|
Round 2: ARM:
I think the following should be fixed by revision bumps: Not sure what happened to
or
|
Yes, PHP will need a revision bump. I remember that from back when I did some icu4c updates. Also remember: |
|
Php 7.2 should be disabled as upstream doesn't support it anymore. |
What's the policy on when we use what? We have the EOL date set as the "deprecation" date. But it sounds like the argument is that should be the "disabled" date instead. I don't disagree in disabling it - but it's worth clarifying at some point. |
I decided against disabling
|
Whoops. Forgot to check the Intel nodes. Should not be working on PRs this late. CI logs before my force-push: https://github.com/Homebrew/homebrew-core/actions/runs/575366417 Outstanding failures are Big Sur:
Catalina:
Mojave:
|
I think this is the
Java is supposed to be optional. It seems to mistakenly think it should be building the Java bindings because of the existence of the
|
Yep. Looks trivial though. Just needs to use a different variable name.
It might have unknowningly relied on the OpenJDK cask (which can be accessed via |
Those will stay until we disable it.
Upstream announced the deprecation 2 years before that and we've removed previous versions when that date hit.
I'll put it on my list to write down a policy regarding this. But my personal view is "as soon as upstream drops support, so do we. Unless we need this version for something internal." |
Ok, updates:
We can just forget about Assuming all goes well, I expect only |
Looks like the
|
Ah yikes. I'll have another look tomorrow. Maybe the whole patch can be simplified a bit. |
It's possible a |
Catalina:
The audit failures are spurious (bad credential errors). Need to look into |
Additionally, add a patch to fix the build.
Additionally, add a build-time dependency on openjdk. Without this, the build fails because the `/usr/bin/java` wrapper confuses the build system into building the Java bindings. This fails without Java installed.
- Fix compilation of [email protected] with icu4c 68. - Disable for one year after deprecation. Co-authored-by: Carlo Cabrera <[email protected]>
Catalina:
Big Sur:
These all appear to be bad GitHub token errors. |
Ugh. |
Another attempt at #65763.