hyperkit 0.20210107

[Bo98]

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

---

[Bo98]

Testing a VM inside of a VM (the CI) is probably going to be a problem here.

[mitchblank]

Was there some progress on Big Sur that isn't yet reflected on moby/hyperkit#297 ?

[Bo98]

Yes, moby/hyperkit#307

[BrewTestBot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[carlocab]

If we can't test this in a sandbox, we may as well just get rid of the test block (or put in some trivial test that will work in a sandbox).

The current bottles are failing tests anyway...

[mitchblank]

If we can't test this in a sandbox, we may as well just get rid of the test block (or put in some trivial test that will work in a sandbox).

IMO the best option would be to leave the test but skip it on CI -- that way it at least can be run manually as part of formula maintenance. However I haven't had luck in the past with getting changes like that past review: #66485 (comment)

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[Bo98]

There's been some changes so the VM environment so let's see if anything's changed here.

[carlocab]

Would be good to add a comment here about how to update these when needed.

[Bo98]

# Error: /usr/local/lib/ocaml/findlib/topfind.cmi
#        is not a compiled interface for this version of OCaml.

Did we not revsion bump ocaml-findlib when updating OCaml?

[carlocab]

Unfortunately not: #71942

But CI didn't pick anything up with ocaml-findlib. ocaml-findlib was even used to build other formulae in the same PR.

[Bo98]

But CI didn't pick anything up with ocaml-findlib. ocaml-findlib was even used to build other formulae in the same PR.

I suppose if it only uses the binary then there's no issues. There'll only be issues if it actually uses it as a library, and opam by default does not use system findlib (which the extra lines in this formula show).

This is certainly the first formula to use the topfind part.

[carlocab]

Oops. We should probably add ocaml-findlib to the comment at the start of the ocaml formula then.

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[cho-m]

Tried another run with updated ocaml-findlib, but now back to failing on testcase again.

EDIT: Haven't been able to get test to work locally, though I am trying via Rosetta layer.
Maybe someone more familiar with hyperkit can have a go at this.

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.