sqlite 3.35.2

[xxyzz]

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

---

I see there is another pr of sqlite 3.34.1, the GitHub action won't run on my forked repo so I don't know if the newer version will pass the tests of other formulas.

[carlocab]

I've triggered a merge for #72928. You'll need to rebase this when the merge is done.

[carlocab]

On ARM:

Error: 5 failed steps!
brew test --retry --verbose cargo-edit
brew linkage --test qt-percona-server
brew test --retry --verbose qt-percona-server
brew test --retry --verbose rbtools
brew test --retry --verbose svtplay-dl

[Moisan]

3.35.2 is out now.

[carlocab]

Big Sur node timed out. Don't think I've seen that before. It didn't even upload any artifacts as a consequence...

[xxyzz]

Wow, it runs three days, that limitation is set at here. sqlite truly is the most used db, is it also the most depended formula in Homebrew?

$ brew uses sqlite --recursive --include-build --include-test | wc -w
2199
$ brew uses sqlite --recursive --include-test | wc -w
947

Homebrew has 5531 formulas currently, that means it need to test about 40% of all the formulas? Jeez.

[Bo98]

You can exclude --include-build - we only test runtime dependencies in most cases.

[Bo98]

Yeah, it’s because there are a select few formulae where we do test build time dependencies (go, ghc, etc.). Line 364 filter build deps out for most cases.

…

On 23 Mar 2021, at 05:57, xxyzz ***@***.***> wrote:  You can exclude --include-build - we only test runtime dependencies in most cases. I never used ruby but it looks like the test-bot has this arg: https://github.com/Homebrew/homebrew-test-bot/blob/master/lib/tests/formulae.rb#L317 — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

[xxyzz]

Yeah, it’s because there are a select few formulae where we do test build time dependencies (go, ghc, etc.). Line 364 filter build deps out for most cases.

I run the brew test-bot --dry-run --only-formulae sqlite command on my mac(intel 11.2.3) and add a few puts to check some variables: @source_dependents is empty and @bottled_dependents.length is 2101...

I'm confused why cargo-edit is in the test, it seems the new sqlite doesn't affect cargo-edit at all in the CI log.

[Bo98]

There's a problem with pruning recursive build deps, which I'm working to fix soon. Shouldn't stop this PR though (that timeout error isn't related to the length - it just got stuck on something).

I'm confused why cargo-edit is in the test, it seems the new sqlite doesn't affect cargo-edit at all in the CI log.

That sort of demonstrates the bug:

cargo-edit -> rust (build) -> [email protected] -> sqlite

We trim sqlite as a build dep, but don't consider that something else in the chain might be a build dep.

[carlocab]

Usual failures. This should probably be good to merge. All the extra ones on (Intel) Big Sur are formulae without bottles.

Big Sur (ARM)

Error: 1 failed step!
brew test --retry --verbose cargo-edit

Big Sur (Intel)

Error: 10 failed steps!
brew test --retry --verbose asuka
brew test --retry --verbose cargo-edit
brew test --retry --verbose creduce
brew test --retry --verbose hyperkit
brew install llvm@8
brew install --only-dependencies oclgrind
brew install oclgrind
brew install pypy
brew install pypy3
brew test --retry --verbose wasm-pack

Catalina

Error: 3 failed steps!
brew test --retry --verbose cargo-edit
brew test --retry --verbose hyperkit
brew test --retry --verbose wasm-pack

Mojave

Error: 5 failed steps!
brew test --retry --verbose cargo-edit
brew test --retry --verbose hyperkit
brew test --retry --verbose opencascade
brew test --retry --verbose swift
brew test --retry --verbose wasm-pack

[carlocab]

Thanks, @xxyzz!

[BrewTestBot]

@carlocab has triggered a merge.