Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Wayland support #152

Merged
merged 5 commits into from
Sep 29, 2024
Merged

More Wayland support #152

merged 5 commits into from
Sep 29, 2024

Conversation

HorlogeSkynet
Copy link
Owner

Reason and / or context

See #151.

How has this been tested ?

Locally + unit tests.

Types of changes :

  • Bug fix (non-breaking change which fixes an issue)
  • Typo / style fix (non-breaking change which improves readability)
  • New feature (non-breaking change which adds functionality)
  • [Breaking change (fix or feature that would cause existing functionality to change)

Checklist :

  • [IF NEEDED] I have updated the README.md file accordingly ;
  • [IF NEEDED] I have updated the test cases (which pass) accordingly ;
  • [IF BREAKING] This pull request targets next Archey version branch ;
  • My changes looks good ;
  • I agree that my code may be modified in the future ;
  • My code follows the code style of this project (PEP8).

@HorlogeSkynet HorlogeSkynet added enhancement ⬆️ Implements a new feature, fixes or improves existing ones backward compatibility ⬇️ This is about a feature not working as expected on old systems labels Apr 14, 2024
@HorlogeSkynet HorlogeSkynet added this to the v4.14.4.0 milestone Apr 14, 2024
@HorlogeSkynet HorlogeSkynet self-assigned this Apr 14, 2024
@HorlogeSkynet
Copy link
Owner Author

  1. @Nagefire sorry for the delay, tests were failing against Python 3.6 ...
  2. @ingrinder sorry (too !) for the future required conflicts for other ongoing work... 😇

Thanks, bye 👋

@HorlogeSkynet HorlogeSkynet force-pushed the feat/more_wayland_support branch 2 times, most recently from 8f823c7 to dba36e8 Compare April 20, 2024 16:44
@ingrinder
Copy link
Collaborator

In my calendar to review around 27th May if you can wait 'til then! Planning to set up a VM with all of the supported DEs/WMs to double-check for any regressions (unless you've already done so!)

@HorlogeSkynet HorlogeSkynet merged commit e11cbfc into master Sep 29, 2024
26 checks passed
@HorlogeSkynet HorlogeSkynet deleted the feat/more_wayland_support branch September 29, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backward compatibility ⬇️ This is about a feature not working as expected on old systems enhancement ⬆️ Implements a new feature, fixes or improves existing ones
Development

Successfully merging this pull request may close these issues.

2 participants