Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GPU] Adds support for Raspberry Pi (VideoCore chipsets) #157

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

HorlogeSkynet
Copy link
Owner

@HorlogeSkynet HorlogeSkynet commented Aug 19, 2024

See #130.

How has this been tested ?

Unit tests and Raspberry Pi 1 (running as root).

Types of changes :

  • Bug fix (non-breaking change which fixes an issue)
  • Typo / style fix (non-breaking change which improves readability)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist :

  • [IF NEEDED] I have updated the README.md file accordingly ;
  • [IF NEEDED] I have updated the test cases (which pass) accordingly ;
  • [IF BREAKING] This pull request targets next Archey version branch ;
  • My changes looks good ;
  • I agree that my code may be modified in the future ;
  • My code follows the code style of this project (PEP8).

@HorlogeSkynet HorlogeSkynet added the enhancement ⬆️ Implements a new feature, fixes or improves existing ones label Aug 19, 2024
@HorlogeSkynet HorlogeSkynet added this to the v4.15.0.0 milestone Aug 19, 2024
@HorlogeSkynet HorlogeSkynet self-assigned this Aug 19, 2024
@MatsA
Copy link

MatsA commented Aug 19, 2024

Hi ! Nice ! Please advice how to test. /Mats

@HorlogeSkynet
Copy link
Owner Author

HorlogeSkynet commented Aug 19, 2024

Sure, first you need to Git clone the project and then checkout the feat/raspberry_pi_gpu branch.
From there you can then create a Python virtual environment and install dependencies, before running Archey from sources :

python3 -m venv venv && source venv/bin/activate
pip install -e .
python3 -m archey

Please note that if your configuration isn't "locked" (see allow_overriding config option), shipped config.json will be preferred over your system/user configuration (if you have any).

Thanks for your time, bye 👋


EDIT : ⚠️ important note, reading in /sys/kernel/debug may require root privileges

@HorlogeSkynet
Copy link
Owner Author

Up @MatsA / @ingrinder 🙇

@MatsA
Copy link

MatsA commented Aug 31, 2024

Sorry, my bad....

Not that good in git cli so googled little and did as below

As said using RPi 5 with desktop

/Mats

git clone -b feat/raspberry_pi_gpu https://github.com/HorlogeSkynet/archey4.git
cd archey4
python3 -m venv venv && source venv/bin/activate
pip install -e .
(venv) pi@test:~/archey4 $ python3 -m archey

Skärmavbild 2024-08-31 kl  22 03 43

@HorlogeSkynet
Copy link
Owner Author

Thanks for trying ! So I guess GPU detection works, but running as root caused WM & DE to be missing.
Maybe running with sudo would satisfy everyone, but that's another concern.

I'm waiting for @ingrinder review before merging this. Thanks again, bye 👋

@MatsA
Copy link

MatsA commented Sep 1, 2024

I'm waiting for @ingrinder review before merging this. Thanks again, bye 👋

Hi, nice I could help. Maybe you shouldn't have high hopes for a ingrinder response since he haven't been active for half a year..... and a student 😉.... maybe having much other things up and running ?

/Mats

@HorlogeSkynet
Copy link
Owner Author

Hi, nice I could help. Maybe you shouldn't have high hopes for a ingrinder response since he haven't been active for half a year..... and a student 😉.... maybe having much other things up and running ?

Indeed, I hope he's okay.
Unfortunately he's the only other maintainer here, and I usually prefer multiple positive reviews before merging something (mostly when it's my own code 🙃).
We're already late for the v4.15 release, I plan to wait until the end of the month before merging everything and eventually releasing it.

Bye 👋

@HorlogeSkynet HorlogeSkynet marked this pull request as draft September 1, 2024 20:21
@HorlogeSkynet HorlogeSkynet marked this pull request as ready for review September 2, 2024 17:27
@HorlogeSkynet
Copy link
Owner Author

(branch has been rebased and AppArmor profile extended according to new opened/read files)

@HorlogeSkynet HorlogeSkynet merged commit 26af175 into master Sep 29, 2024
26 checks passed
@HorlogeSkynet HorlogeSkynet deleted the feat/raspberry_pi_gpu branch September 29, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ⬆️ Implements a new feature, fixes or improves existing ones
Development

Successfully merging this pull request may close these issues.

2 participants