Fix is not syntax highlighting
#260
Merged
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-malt
commented
Jan 26, 2024
| @@ -37,7 +37,7 @@ To enable Emmet on your `html-hubl` files, you can map `html-hubl` to `html` in | |||
|
|
|||
| ### IntelliSense Suggestions | |||
|
|
|||
| If you are would like to get IntelliSense suggestions when in snippet placeholders, you will need to add the following to your user settings: | |||
| If you would like to get IntelliSense suggestions when in snippet placeholders, you will need to add the following to your user settings: | |||
Comment on lines
+109
to
+112
| { | ||
| "match": "\\b(and|else|if|in|import|(is )?not|or|recursive|with(out)?\\s+context)\\b", | ||
| "name": "keyword.control.hubl" | ||
| }, |
There was a problem hiding this comment.
I moved this up in the file so that it takes precedence over the x is y syntax highlighting, which was breaking the x is not y syntax highlight, since it was being captured as x (is) not y instead of x (is not) y. I've also added the optional group (is )? so it captures is not here.
| @@ -115,7 +119,7 @@ | |||
| "name": "variable.other.hubl.test" | |||
| } | |||
| }, | |||
| "match": "\\s*\\b(is)\\s+([a-zA-Z_][a-zA-Z0-9_]*)\\b" | |||
| "match": "\\s*\\b(is)(?!\\s+not)\\s+([a-zA-Z_][a-zA-Z0-9_]*)\\b" | |||
There was a problem hiding this comment.
Added a non-capturing group for is so that this doesn't match x is not y, only x is y. We need to keep this group around because the alternative (adding is to the group above) would match independent is tokens incorrectly, so x not is y would get highlighted as an operator which seems undesirable (really we should error on that but outside the scope of this change).
TanyaScales
approved these changes
Jan 26, 2024
Closed
This was
linked to
issues
Jan 29, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Issue #257
The token
is notwas being incorrectly captured in our syntax. This PR updates the syntax regex to correctly capture this token. Here is a test snippet from the original issue, and the updated syntax highlighting:Before
After