Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating from upstream #1

Open
wants to merge 66 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
66 commits
Select commit Hold shift + click to select a range
fb0dd55
feat: add S3 bucket key support (#236)
nozaq Nov 22, 2021
141fd66
bump up the version
nozaq Nov 22, 2021
1b0f314
feat: apply default subnet changes to existing subnets (#237)
jgeurts Dec 11, 2021
0c39831
fix: remove `aws_default_vpc` dependency (#238)
nozaq Dec 11, 2021
cf9b14c
feat: optionally ignore SSO logins for MFA alarms (#234)
mzupan Dec 11, 2021
3366cac
fix: use CIS recommended filter pattern (#239)
nozaq Dec 11, 2021
acd1464
refactor: use module count instead of having ennabled variable in eac…
nozaq Jan 7, 2022
ceabfc7
feat: add inputs to toggle submodules (#240)
nozaq Jan 8, 2022
31eae8f
feat: enable finding aggregator in the main region (#241)
nozaq Jan 8, 2022
fe04519
bump up the version
nozaq Jan 8, 2022
acf193e
style: follow the official style conventions (#242)
nozaq Jan 9, 2022
1e088b4
refactor: re-organize locals (#243)
nozaq Jan 9, 2022
2b8cc0e
style: apply consistent comment style (#244)
nozaq Jan 9, 2022
ca731bd
style: replace `//` style comment (#245)
nozaq Jan 9, 2022
d95aad5
refactor: add tflint checks (#246)
nozaq Jan 9, 2022
3c743e6
bump up the version
nozaq Jan 9, 2022
2d28384
docs: sort inputs by required (#247)
nozaq Jan 10, 2022
6742a37
fix: upgrade minimum provider requirements (#248)
nozaq Jan 10, 2022
bab4564
style: update editorconfig (#249)
nozaq Jan 10, 2022
3933087
docs: the additional space ' ' after source on line 5 causes terrafor…
CurtisSSE Jan 14, 2022
6bc61ca
feat: enforce strong password policy by default (#252)
nozaq Jan 15, 2022
4d3cbd4
fix: set the minimum terraform version to 1.1.4 (#255)
nozaq Jan 20, 2022
aa478e1
feat: automatically accepts invite from the master (#256)
nozaq Jan 22, 2022
85864f5
fix: no findings aggregator for member accounts (#257)
nozaq Jan 22, 2022
427c9e1
docs: update CHANGELOG
nozaq Jan 22, 2022
eb83ce3
chore: update issue templates
nozaq Jan 23, 2022
0b636bb
feat: allow use of organization trail to be toggled via variable (#259)
jamiezieziula Feb 12, 2022
150a537
feat: add new S3 bucket configuration resources (#261)
nozaq Feb 12, 2022
8fda7c7
fix: use count instead of `var.enabled` (#262)
nozaq Feb 12, 2022
0b9bfe1
refactor: replace deprecated arguments (#263)
nozaq Feb 12, 2022
f5d6b3d
refactor: explicitly define a format for FlowLogs (#264)
nozaq Feb 12, 2022
5f63932
fix: the condition to use the organization trail (#265)
nozaq Feb 12, 2022
900dd6f
chore: upgrade go dependencies (#266)
nozaq Feb 12, 2022
91d4378
refactor: remove `destination_options` (#267)
nozaq Feb 12, 2022
01b9ad8
docs: update CHANGELOG
nozaq Feb 12, 2022
05dd88c
fix: require AWS provider v4.1.0 (#268)
nozaq Feb 16, 2022
ab6f5ac
chore: upgrade terratest (#269)
nozaq Feb 19, 2022
3c30413
fix: require AWS provider v4.2.0 (#270)
nozaq Feb 19, 2022
4575e2c
docs: update CHANGELOG
nozaq Feb 19, 2022
be4f291
docs: update badges (#271)
nozaq Feb 20, 2022
3dc1be8
docs: add a compatibility notice
nozaq Feb 25, 2022
8612941
fix: mark `var.member_accounts` required (#272)
nozaq Feb 25, 2022
0122d6f
fix: avoid for_each key error (#273)
nozaq Feb 25, 2022
e8c7ddf
docs: update the release badge link (#275)
nozaq Mar 5, 2022
897545d
chore: enable release-please action (#276)
nozaq Mar 6, 2022
9b83049
docs: minor style fix
nozaq Mar 6, 2022
2e439b9
chore(main): release 1.0.1 (#277)
github-actions[bot] Mar 6, 2022
ffcbb69
chore: use https protocol (#278)
nozaq Mar 15, 2022
83b2750
docs: use "keep a changelog" format (#279)
nozaq Mar 16, 2022
7041247
chore: update dependencies (#281)
nozaq Mar 31, 2022
c695553
docs: fix a typo in compliance.md (#283)
uakbr Apr 16, 2022
2b471bd
feat: use S3 lifecycle rule V2 (#285)
nozaq Apr 16, 2022
271d99e
fix: upgrade the AWS provider to v4.3 (#287)
nozaq Apr 16, 2022
e7d422d
chore(main): release 1.1.0 (#286)
github-actions[bot] Apr 17, 2022
8f693c5
docs: add the missing import guidance (#289)
nozaq May 14, 2022
a94ba14
build: upgrade dependencies (#290)
nozaq Jun 2, 2022
f0cdf3e
feat: make glacier transition rules optional (#293)
nozaq Jun 5, 2022
219f003
feat: add permissions boundaries for IAM entities support (#288)
SergK Jun 5, 2022
d804dc6
chore(main): release 2.0.0 (#294)
github-actions[bot] Jun 5, 2022
7c372cd
build: upgrade terratest (#295)
nozaq Jun 8, 2022
99f0493
build: upgrade dependencies (#296)
nozaq Jun 17, 2022
07dc101
feat: make audit log bucket access logs bucket name customizable (#303)
K3ndu Oct 2, 2022
bb724cd
feat: enable CIS benchmark v1.4.0 standard (#308)
nozaq Dec 3, 2022
7c4a1e5
chore(main): release 2.1.0 (#304)
github-actions[bot] Dec 3, 2022
d4b50de
chore: add devcontainer configuration (#312)
nozaq Jan 14, 2023
6b2d679
chore: remove stale tests (#315)
nozaq Feb 22, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
FROM mcr.microsoft.com/devcontainers/base:bullseye

RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \
&& apt-get -y install --no-install-recommends python3-pip \
&& pip install --no-input pre-commit
21 changes: 21 additions & 0 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"name": "Terraform",
"build": {
"dockerfile": "./Dockerfile",
"context": "."
},
"features": {
"ghcr.io/devcontainers/features/terraform:1": {
"version": "latest",
"installTerraformDocs": true
}
},
"customizations": {
"vscode": {
"extensions": [
"EditorConfig.EditorConfig"
]
}
},
"postCreateCommand": "pre-commit install"
}
9 changes: 6 additions & 3 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
root = true

[*]
charset = utf-8
end_of_line = lf
indent_style = space
indent_size = 2
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true
max_line_length = 80
trim_trailing_whitespace = true

[*.md]
trim_trailing_whitespace = false
max_line_length = 0
trim_trailing_whitespace = false
36 changes: 36 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
---
name: Bug report
about: Create a report to help us improve
title: ''
labels: bug
assignees: ''

---

## Describe the bug

<!-- A clear and concise description of what the bug is. -->

## Versions

<!-- Provide the versions of terraform, the AWS provider and this module you're using -->

- Terraform:
- Provider:
- Module:

## Reproduction

<!-- Steps to reproduce the behavior: -->

## Expected behavior

<!-- A clear and concise description of what you expected to happen. -->

## Actual behavior

<!-- A clear and concise description of what actually happened. -->

## Additional context

<!-- Add any other context about the problem here. -->
24 changes: 24 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
---
name: Feature request
about: Suggest an idea for this project
title: ''
labels: enhancement
assignees: ''

---

## Is your feature request related to a problem? Please describe.

<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -->

## Describe the solution you'd like

<!-- A clear and concise description of what you want to happen. -->

## Describe alternatives you've considered

<!-- Optional. A clear and concise description of any alternative solutions or features you've considered. -->

## Additional context

<!-- Add any other context or screenshots about the feature request here. -->
18 changes: 11 additions & 7 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
@@ -1,20 +1,24 @@
name: Terraform
name: CI
on:
push:
branches:
- main
pull_request:
jobs:
check-format:
name: Check format
pre-commit-checks:
name: Pre-commit checks
runs-on: ubuntu-latest
steps:
- uses: hashicorp/setup-terraform@v1
- name: Checkout
uses: actions/checkout@v2
- name: "Terraform Format"
run: terraform fmt -check -recursive

- name: Terraform min/max versions
id: minMax
uses: clowdhaus/[email protected]
- name: Pre-commit Terraform ${{ steps.minMax.outputs.maxVersion }}
uses: clowdhaus/terraform-composite-actions/[email protected]
with:
terraform-version: ${{ steps.minMax.outputs.maxVersion }}
terraform-docs-version: v0.16.0
validate-examples:
name: Validate examples
runs-on: ubuntu-latest
Expand Down
12 changes: 12 additions & 0 deletions .github/workflows/release-please.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
on:
push:
branches:
- main
name: release-please
jobs:
release-please:
runs-on: ubuntu-latest
steps:
- uses: google-github-actions/release-please-action@v3
with:
release-type: terraform-module
10 changes: 8 additions & 2 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
repos:
- repo: git://github.com/antonbabenko/pre-commit-terraform
rev: v1.51.0
- repo: https://github.com/antonbabenko/pre-commit-terraform
rev: v1.62.3
hooks:
- id: terraform_fmt
- id: terraform_docs
args:
- --args=--config=.terraform-docs.yml
- id: terraform_tflint
exclude: "test/"
args:
- --args=--config=__GIT_WORKING_DIR__/.tflint.hcl
16 changes: 16 additions & 0 deletions .terraform-docs.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
formatter: "markdown table"

sections:
show:
- requirements
- providers
- inputs
- outputs

sort:
enabled: true
by: required

settings:
default: false
lockfile: false
53 changes: 53 additions & 0 deletions .tflint.hcl
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
config {
module = false
force = false
disabled_by_default = false
}

rule "terraform_deprecated_interpolation" {
enabled = true
}

rule "terraform_deprecated_index" {
enabled = true
}

rule "terraform_unused_declarations" {
enabled = true
}

rule "terraform_comment_syntax" {
enabled = true
}

rule "terraform_documented_outputs" {
enabled = true
}

rule "terraform_documented_variables" {
enabled = true
}

rule "terraform_typed_variables" {
enabled = true
}

rule "terraform_module_pinned_source" {
enabled = true
}

rule "terraform_required_version" {
enabled = true
}

rule "terraform_required_providers" {
enabled = true
}

rule "terraform_standard_module_structure" {
enabled = true
}

rule "terraform_workspace_remote" {
enabled = true
}
121 changes: 118 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,115 @@
<a name="unreleased"></a>
## [Unreleased]
# Changelog
All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [2.1.0](https://github.com/nozaq/terraform-aws-secure-baseline/compare/v2.0.0...v2.1.0) (2022-12-03)


### Features

* enable CIS benchmark v1.4.0 standard ([#308](https://github.com/nozaq/terraform-aws-secure-baseline/issues/308)) ([bb724cd](https://github.com/nozaq/terraform-aws-secure-baseline/commit/bb724cd7783ae3e645cbbb4468b367fc5095cb53))
* make audit log bucket access logs bucket name customizable ([#303](https://github.com/nozaq/terraform-aws-secure-baseline/issues/303)) ([07dc101](https://github.com/nozaq/terraform-aws-secure-baseline/commit/07dc101179fa2d1649cd987e3d8f3d269db546b8))

## [2.0.0](https://github.com/nozaq/terraform-aws-secure-baseline/compare/v1.1.0...v2.0.0) (2022-06-05)


### ⚠ BREAKING CHANGES

* this change disables glacier transition rules by default since transitioning small objects is officially not recommended. it can be enabled by setting `var.audit_log_lifecycle_glacier_transition_days` to a positive number.

### Features

* add permissions boundaries for IAM entities support ([#288](https://github.com/nozaq/terraform-aws-secure-baseline/issues/288)) ([219f003](https://github.com/nozaq/terraform-aws-secure-baseline/commit/219f0032626a793b1c7ca304793d924b829b2c18))
* make glacier transition rules optional ([#293](https://github.com/nozaq/terraform-aws-secure-baseline/issues/293)) ([f0cdf3e](https://github.com/nozaq/terraform-aws-secure-baseline/commit/f0cdf3e6294a97ef455cf5e313aba14bfba38467))

## [1.1.0](https://github.com/nozaq/terraform-aws-secure-baseline/compare/v1.0.1...v1.1.0) (2022-04-16)


### Features

* use S3 lifecycle rule V2 ([#285](https://github.com/nozaq/terraform-aws-secure-baseline/issues/285)) ([2b471bd](https://github.com/nozaq/terraform-aws-secure-baseline/commit/2b471bd321f3f7503690076d9321aeca38401796))


### Bug Fixes

* upgrade the AWS provider to v4.3 ([#287](https://github.com/nozaq/terraform-aws-secure-baseline/issues/287)) ([271d99e](https://github.com/nozaq/terraform-aws-secure-baseline/commit/271d99ef6206fab0886f6961674340e986b5bc0c))

## [1.0.1](https://github.com/nozaq/terraform-aws-secure-baseline/compare/v1.0.0...v1.0.1) (2022-03-06)
### Bug Fixes
- avoid for_each key error ([#273](https://github.com/nozaq/terraform-aws-secure-baseline/issues/273)) ([0122d6f](https://github.com/nozaq/terraform-aws-secure-baseline/commit/0122d6fcd00ecd1114a2d5e7853027ebb0322d71))
- mark `var.member_accounts` required ([#272](https://github.com/nozaq/terraform-aws-secure-baseline/issues/272)) ([8612941](https://github.com/nozaq/terraform-aws-secure-baseline/commit/8612941317db8c5f3eb82fd8c5218b8ef5a5d41f))

## [1.0.0] - 2022-02-19
### Feat
- add new S3 bucket configuration resources ([#261](https://github.com/nozaq/terraform-aws-secure-baseline/issues/261))
- allow use of organization trail to be toggled via variable ([#259](https://github.com/nozaq/terraform-aws-secure-baseline/issues/259))

### Fix
- require AWS provider v4.2.0 ([#270](https://github.com/nozaq/terraform-aws-secure-baseline/issues/270))
- require AWS provider v4.1.0 ([#268](https://github.com/nozaq/terraform-aws-secure-baseline/issues/268))
- the condition to use the organization trail ([#265](https://github.com/nozaq/terraform-aws-secure-baseline/issues/265))
- use count instead of `var.enabled` ([#262](https://github.com/nozaq/terraform-aws-secure-baseline/issues/262))

### Refactor
- remove `destination_options` ([#267](https://github.com/nozaq/terraform-aws-secure-baseline/issues/267))
- explicitly define a format for FlowLogs ([#264](https://github.com/nozaq/terraform-aws-secure-baseline/issues/264))
- replace deprecated arguments ([#263](https://github.com/nozaq/terraform-aws-secure-baseline/issues/263))

### BREAKING CHANGE

resources regarding S3 bucket configurations need manual import
after upgrade. See `docs/upgrade-1.0.md` for guidance.


<a name="0.34.0"></a>
## [0.34.0] - 2022-01-22
### Feat
- automatically accepts invite from the master ([#256](https://github.com/nozaq/terraform-aws-secure-baseline/issues/256))
- enforce strong password policy by default ([#252](https://github.com/nozaq/terraform-aws-secure-baseline/issues/252))

### Fix
- no findings aggregator for member accounts ([#257](https://github.com/nozaq/terraform-aws-secure-baseline/issues/257))
- set the minimum terraform version to 1.1.4 ([#255](https://github.com/nozaq/terraform-aws-secure-baseline/issues/255))
- upgrade minimum provider requirements ([#248](https://github.com/nozaq/terraform-aws-secure-baseline/issues/248))


<a name="0.33.0"></a>
## [0.33.0] - 2022-01-10
### Refactor
- add tflint checks ([#246](https://github.com/nozaq/terraform-aws-secure-baseline/issues/246))
- re-organize locals ([#243](https://github.com/nozaq/terraform-aws-secure-baseline/issues/243))


<a name="0.32.0"></a>
## [0.32.0] - 2022-01-08
### Feat
- enable finding aggregator in the main region ([#241](https://github.com/nozaq/terraform-aws-secure-baseline/issues/241))


<a name="0.31.0"></a>
## [0.31.0] - 2022-01-08
### Feat
- add inputs to toggle submodules ([#240](https://github.com/nozaq/terraform-aws-secure-baseline/issues/240))
- optionally ignore SSO logins for MFA alarms ([#234](https://github.com/nozaq/terraform-aws-secure-baseline/issues/234))
- apply default subnet changes to existing subnets ([#237](https://github.com/nozaq/terraform-aws-secure-baseline/issues/237))

### Fix
- use CIS recommended filter pattern ([#239](https://github.com/nozaq/terraform-aws-secure-baseline/issues/239))
- remove `aws_default_vpc` dependency ([#238](https://github.com/nozaq/terraform-aws-secure-baseline/issues/238))

### Refactor
- use module count instead of having ennabled variable in each submodule. ([#195](https://github.com/nozaq/terraform-aws-secure-baseline/issues/195))


<a name="0.30.0"></a>
## [0.30.0] - 2021-11-23
### Feat
- add S3 bucket key support ([#236](https://github.com/nozaq/terraform-aws-secure-baseline/issues/236))

### Fix
- the minimum required version of the AWS provider ([#227](https://github.com/nozaq/terraform-aws-secure-baseline/issues/227))


<a name="0.29.2"></a>
Expand Down Expand Up @@ -344,7 +454,12 @@
<a name="0.0.1"></a>
## 0.0.1 - 2018-02-12

[Unreleased]: https://github.com/nozaq/terraform-aws-secure-baseline/compare/0.29.2...HEAD
[1.0.0]: https://github.com/nozaq/terraform-aws-secure-baseline/compare/0.34.0...1.0.0
[0.34.0]: https://github.com/nozaq/terraform-aws-secure-baseline/compare/0.33.0...0.34.0
[0.33.0]: https://github.com/nozaq/terraform-aws-secure-baseline/compare/0.32.0...0.33.0
[0.32.0]: https://github.com/nozaq/terraform-aws-secure-baseline/compare/0.31.0...0.32.0
[0.31.0]: https://github.com/nozaq/terraform-aws-secure-baseline/compare/0.30.0...0.31.0
[0.30.0]: https://github.com/nozaq/terraform-aws-secure-baseline/compare/0.29.2...0.30.0
[0.29.2]: https://github.com/nozaq/terraform-aws-secure-baseline/compare/0.29.1...0.29.2
[0.29.1]: https://github.com/nozaq/terraform-aws-secure-baseline/compare/0.29.0...0.29.1
[0.29.0]: https://github.com/nozaq/terraform-aws-secure-baseline/compare/0.28.0...0.29.0
Expand Down
Loading