fix: allow assistant end messages to be sent to parent #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DawidWraga is attempting to deploy a commit to the Hume Team on Vercel. A member of the Team first needs to authorize it. |
yinishi
approved these changes
Aug 27, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks for contributing this fix, @DawidWraga. We'll include this in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zachkrall Thank you for attempting to fix this issue in your recent commits.
While the the voice client now handles
assistant_endmessages, the message store does not. This means that theonMessagehandler passed to theVoiceProviderstill does not supportassistant_endmessages.I have implemented the fix here