-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quality of exported image #2
Comments
@ksobon
|
If I remember right @chriswmackey made a limitation for the size but still the images from Grasshopper canvas are pretty high resolution and readable. I like the approach number 4. If we figure out the exact maximum size we can break up larger images into a grid of images and let the user slide between them. |
Just to get the node working I used the built in method Dynamo uses for the screenshot but I am in the process of trying to rewrite this for both the 3D background preview and canvas. I need to revisit the Grasshopper component and see how Chris went about it as well. |
@mostaphaRoudsari , @mdahlhausen , @ksobon , and @alfarok , I put in a max size to the image of the GH canvass to stop my personal browser from crashing but I realize that everyone's browser and system is a bit different and it's hard to make a "one size fits all" script this way. @mdahlhausen , -Chris |
@chriswmackey yep just split the image into different portions, and we can scroll through them on the viewer. This will help a bit, but I still expect some issues. I'm thinking maybe disabling the pan/zoom is a better option, and just including a note that it was disabled because the file was too big might be a better fix. That way we know we won't crash the client. And is a user wants to pan/zoom, they can download the image. We can try both. |
@mdahlhausen , Right now, I think that we all agree that this one is too big: Is this one too big? -Chris |
@chriswmackey I think they both are; the first one crashed my client, and the second one is really sluggish. And I've got a pretty heavy duty pc. I'm reconsidering splitting the image. I don't think it will help the problem; it'll scale by the number of times we break up the image, but we need an order of magnitude reduction (or several) in image size. |
@mdahlhausen , |
@chriswmackey let's cap it at 2 million pixels. It really should be smaller for mobile devices, about a half million pixels. I think we can program the logic about what size to display into the webpage, but for now lets go with the larger cap. For reference, your outdoor microclimate map grasshopper image is ~75 million pixels and ~4 MB. |
I have a rather large definition and exported image is unfortunately not big enough making the nodes unreadable (pixelated). Maybe we can add additional input for quality or figure out a way to make sure that when images are exported they are large enough that can be read later.
The text was updated successfully, but these errors were encountered: