Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI datasets ordering starting from 0 #2106

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

lampajr
Copy link
Member

@lampajr lampajr commented Oct 21, 2024

Currently in the UI the datasets ordering is starting from 1, whereas the ordering in the backend start from 0.
This could create some confusion, when both conventions are reported in the UI, e.g., #2093.

Moreover, all the urls that contain some datasets identifiers use the backend convention (starting from 0).

My proposal is to unify the convention and make use of the 0ed one, this would also simplify its management in the UI.

Changes proposed

  • Keep the same datasets ordering between backend and UI

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.

Signed-off-by: Andrea Lamparelli <[email protected]>
@lampajr lampajr merged commit cc2fdc8 into Hyperfoil:master Oct 25, 2024
3 checks passed
@lampajr lampajr deleted the changes_dataset_id branch October 25, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants