Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split add and update schema apis #2298

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lampajr
Copy link
Member

@lampajr lampajr commented Mar 6, 2025

Changes proposed

Schema

  • Split add and update APIs for Schema creation and update
  • Use POST for creation
  • Use PUT for update
  • Return 201 for creation
  • Return 200 for update
  • Update the tests accordingly
  • Update the UI

Labels

  • Split add and update APIs for Schema Labels creation and update
  • Use POST for creation
  • Use PUT for update
  • Return 201 for creation
  • Return 200 for update
  • Update the tests accordingly
  • Update the UI

Transformers

  • Split add and update APIs for Schema Transformers creation and update
  • Use POST for creation
  • Use PUT for update
  • Return 201 for creation
  • Return 200 for update
  • Update the tests accordingly
  • Update the UI

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@stalep
Copy link
Member

stalep commented Mar 7, 2025

I've not tested the web changes, but it looks good!

Signed-off-by: Andrea Lamparelli <[email protected]>
@lampajr lampajr force-pushed the split_add_update_schema branch 2 times, most recently from e5ff803 to 085cd51 Compare March 8, 2025 09:18
@lampajr lampajr force-pushed the split_add_update_schema branch from 085cd51 to 8595d85 Compare March 8, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants