Close jump host shell after stopping container: Fixes #209 #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes local container subshells but remote container subshells appear to remain open for the initial ContainerShell sub shell (the one opened for stopContainers... is closed). I will open a new issue for that part of the problem. |
willr3
approved these changes
Jun 10, 2024
johnaohara
added a commit
to johnaohara/qDup
that referenced
this pull request
Jun 19, 2024
…yperfoil#211) Co-authored-by: willr3 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #209 by closing the jump host shell used to stop the container for containerShell