Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Separate file field in django form constructor #4121

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

theSage21
Copy link

@theSage21 theSage21 commented Sep 30, 2024

Fixes: #4093

Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Arjoon, this looks great!

The only other thing we need before merging is some automated tests, so that we can tell if someone accidentally breaks this feature in a future PR.

hypothesis-python/RELEASE.rst Outdated Show resolved Hide resolved
@theSage21
Copy link
Author

Thanks Arjoon, this looks great!

The only other thing we need before merging is some automated tests, so that we can tell if someone accidentally breaks this feature in a future PR.

Hey! I will add those soon. Currently caught up in work so not able to give time to this.

@Zac-HD Zac-HD force-pushed the from_form branch 2 times, most recently from 2b76d80 to 2aa3ac2 Compare January 27, 2025 05:08
@Zac-HD
Copy link
Member

Zac-HD commented Jan 27, 2025

👋 @theSage21 - I've rebased this on master to pick up some recent CI changes, and fixed a few linter and import errors. I think all that's left is the new test failing 🙂

@theSage21
Copy link
Author

👋 @theSage21 - I've rebased this on master to pick up some recent CI changes, and fixed a few linter and import errors. I think all that's left is the new test failing 🙂

Hi!

Thanks a lot for the rebase!
I haven't found time in a long time to work on this again. I've pushed a few changes now, if they pass all good otherwise I'll see if I can sit down on a weekend and get this done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

django from_form does not work with filefields
2 participants