-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Separate file field in django form constructor #4121
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Arjoon, this looks great!
The only other thing we need before merging is some automated tests, so that we can tell if someone accidentally breaks this feature in a future PR.
Hey! I will add those soon. Currently caught up in work so not able to give time to this. |
Co-authored-by: Zac Hatfield-Dodds <[email protected]>
2b76d80
to
2aa3ac2
Compare
👋 @theSage21 - I've rebased this on master to pick up some recent CI changes, and fixed a few linter and import errors. I think all that's left is the new test failing 🙂 |
Hi! Thanks a lot for the rebase! |
Fixes: #4093