Abu UI d2 4557 gcp validation support #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abuabraham-ttd
force-pushed
the
abu-UID2-4557-gcp-validation-support
branch
from
3c9d7ac to
0dc1151
Compare
abuabraham-ttd
force-pushed
the
abu-UID2-4557-gcp-validation-support
branch
from
44b8db7 to
26250e1
Compare
abuabraham-ttd
commented
Jan 13, 2025
abuabraham-ttd
commented
Jan 13, 2025
abuabraham-ttd
force-pushed
the
abu-UID2-4557-gcp-validation-support
branch
from
f843bd6 to
45d9791
Compare
abuabraham-ttd
force-pushed
the
abu-UID2-4557-gcp-validation-support
branch
from
692be5b to
b55d7dd
Compare
abuabraham-ttd
force-pushed
the
abu-UID2-4557-gcp-validation-support
branch
from
08c97cd to
7712ad0
Compare
abuabraham-ttd
force-pushed
the
abu-UID2-4557-gcp-validation-support
branch
from
f4cfd15 to
274955f
Compare
abuabraham-ttd
force-pushed
the
abu-UID2-4557-gcp-validation-support
branch
from
d6879f5 to
0f5bce3
Compare
abuabraham-ttd
force-pushed
the
abu-UID2-4557-gcp-validation-support
branch
from
69962c8 to
51f77f7
Compare
abuabraham-ttd
force-pushed
the
abu-UID2-4557-gcp-validation-support
branch
from
70199f2 to
8975de3
Compare
abuabraham-ttd
force-pushed
the
abu-UID2-4557-gcp-validation-support
branch
from
866a756 to
aa91898
Compare
abuabraham-ttd
force-pushed
the
abu-UID2-4557-gcp-validation-support
branch
from
d7910dd to
35d0a2f
Compare
abuabraham-ttd
force-pushed
the
abu-UID2-4557-gcp-validation-support
branch
from
aae414f to
c6cd256
Compare
abuabraham-ttd
force-pushed
the
abu-UID2-4557-gcp-validation-support
branch
from
9b9de8b to
42af513
Compare
abuabraham-ttd
commented
Jan 21, 2025
clarkxuyang
reviewed
Jan 21, 2025
clarkxuyang
reviewed
Jan 21, 2025
scripts/gcp-oidc/gcp.py
Outdated
| secret_version_name = f"{os.getenv("API_TOKEN_SECRET_NAME")}" | ||
| response = client.access_secret_version(name=secret_version_name) | ||
| secret_value = response.payload.data.decode("UTF-8") | ||
| except PermissionDenied or DefaultCredentialsError : |
There was a problem hiding this comment.
critical: log the original exception stack, and/or pass it to TTD custom exceptions to log in the upper layer.
clarkxuyang
reviewed
Jan 21, 2025
clarkxuyang
reviewed
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.