Runtime config retrieval and application #1290

BehnamMozafari · 2025-01-16T08:45:37Z

UIDOperatorVerticle gets latest config from injected IConfigService on each request and attaches it to routingcontext
Currently `"refresh_token_expires_after_seconds", "identity_token_expires_after_seconds", "refresh_identity_token_after_seconds", "max_bidstream_lifetime_seconds", "sharing_token_expiry_seconds" and "max_sharing_lifetime_seconds" are updated on each request.
ConfigService implements IConfigService and has a ConfigRetriever injected into it, which retrieves config from the core endpoint
Feature Flag:
/conf/remote-config-feat-flag/remote-config-feat-flag.json used to toggle feature flag, will be overridden by volume mounted configmap
featureFlagConfigRetriever in Main.run() listens to changes in remote-config-feat-flag.json and calls ConfigServiceManager
ConfigServiceManager manages active config service through DelegatingConfigService (which implements IConfigService).

…tants and config.

…edConfig method rather than storing config

…e in UIDOperatorVerticleTest "identity_token_expires_after_seconds", "max_bidstream_lifetime_seconds", "max_sharing_lifetime_seconds" and "sharing_token_expiry_seconds" now are retrieved from RoutingContext in handlers.

…orVerticle

…nfigService Moved validation logic from UIDOperatorVerticle and UIDOperatorService to ConfigValidatorUtil configValidationHandler is set as a config processor for configRetriever in ConfigService

…e UIDOperatorServiceTest

…rticle, Updated UIDOperatorVerticleTest

…erticleTest

…datorUtilTest to test handling null values

ConfigService returns a Future when created and takes ConfigRetriever in "create" method "run()" method in Main waits for ConfigService Future to complete before creating UIDOperatorVerticle

Removed use of reflection to access private attributes/methods Removed unnecessary tests Updated remaining tests to inject ConfigRetriever into ConfigService

…ication # Conflicts: # src/main/java/com/uid2/operator/Main.java # src/main/java/com/uid2/operator/service/UIDOperatorService.java

Set http store to optional

Added default value for max_bidstream_lifetime_seconds

ConfigServiceManager handles switching between dynamic and static config StaticConfigService implements IConfigService, serving config from static files

Main creates new ConfigServiceManager instance and injects it into UIDOperatorVerticle Also Added feature flag config value to local-config.json, Made create method static in ConfigServiceManager

Removed ConfigServiceManager from constructor

Allows for switches between static and dynamic config services without having to change UIDOperatorVerticle

ConfigRetriever in Main listens for feature flag changes and publishes to eventbus ConfigServiceManager listens to eventbus and updates DelegatingConfigService active ConfigService

Added tests to verify config changes are reflected in endpoints

static config values are set from main config rather than ConfigService

- removed bootstrap config as a store from ConfigRetrieverFactory

- exclusive config retriever to listen to changes in mounted configmap - listener directly interacts with ConfigServiceManager rather than publishing to EventBus

scripts/aws/conf/integ-uid2-config.json

src/main/java/com/uid2/operator/vertx/UIDOperatorVerticle.java

src/main/java/com/uid2/operator/Main.java

- Made feature flag json file generic - Small refactoring

- ConfigRetrieverFactory now creates ConfigRetriever from bootstrap config - Add runtime-config-defaults.json to serve as defaults for running locally

src/main/java/com/uid2/operator/Const.java

src/main/java/com/uid2/operator/service/ConfigService.java

src/main/java/com/uid2/operator/service/ConfigServiceManager.java

src/main/java/com/uid2/operator/service/ConfigValidatorUtil.java

src/main/java/com/uid2/operator/service/UIDOperatorService.java

- Refactor Const names in Const.Config - Update ConfigValidatorUtil log messages

conf/local-config.json

src/main/java/com/uid2/operator/service/ConfigValidatorUtil.java

src/main/java/com/uid2/operator/Main.java

src/test/java/com/uid2/operator/benchmark/BenchmarkCommon.java

src/main/java/com/uid2/operator/Main.java

src/main/java/com/uid2/operator/vertx/UIDOperatorVerticle.java

src/main/java/com/uid2/operator/service/DelegatingConfigService.java

src/main/java/com/uid2/operator/service/UIDOperatorService.java

conf/local-config.json

conf/runtime-config-defaults.json

src/test/java/com/uid2/operator/benchmark/BenchmarkCommon.java

src/test/java/com/uid2/operator/UIDOperatorVerticleTest.java

src/main/java/com/uid2/operator/service/ConfigServiceManager.java

src/main/java/com/uid2/operator/service/ConfigRetrieverFactory.java

src/main/java/com/uid2/operator/service/ConfigService.java

src/main/java/com/uid2/operator/service/ConfigValidatorUtil.java

src/main/java/com/uid2/operator/Main.java

- update config scan period for local-config.json - remove unnecessary config values - make ConfigRetrieverFactory create method static - extract runtime config creation to helper method in Main - Added token config validation to UIDOperatorService

- fix type inconsistencies - minor code cleanup - replace getConfig() method from BenchmarkCommon with final static fields

- Copy feat-flag.json file in dockerfiles - Remove unnecessary config values - Add runtime_config_store config value

…orService)

BehnamMozafari added 30 commits December 16, 2024 14:35

Added ConfigService interface and concrete class. Added required cons…

eb9577c

…tants and config.

Add config to RoutingContext and implement ConfigService injection

c985841

Updated ConfigService getConfig method to use ConfigRetriever getCach…

83fe8d7

…edConfig method rather than storing config

Updated UIDOperatorService to get "identity_v3" config from UIDOperat…

c7a788f

…orVerticle

Added ConfigValidatorUtil, Added configValidationHandler method to Co…

cfd6a6a

…nfigService Moved validation logic from UIDOperatorVerticle and UIDOperatorService to ConfigValidatorUtil configValidationHandler is set as a config processor for configRetriever in ConfigService

Updated UIDOperatorService to take config as method parameters, Updat…

975f6ab

…e UIDOperatorServiceTest

Removed setMaxSharingLifetimeSeconds metho from ExtendedUIDOperatorVe…

491025b

…rticle, Updated UIDOperatorVerticleTest

Added ConfigValidatorUtilTest, Removed unused imports in UIDOperatorV…

8018196

…erticleTest

Updated ConfigValidatorUtil to handle null values, Updated ConfigVali…

cd23998

…datorUtilTest to test handling null values

Fixed httpStore in ConfigService

bde83a5

Added ConfigServiceTest

8478fd2

Added ConfigRetrieverFactory to create vert.x ConfigRetriever

8aee5a3

Updated ConfigService, Main

8f40ba2

ConfigService returns a Future when created and takes ConfigRetriever in "create" method "run()" method in Main waits for ConfigService Future to complete before creating UIDOperatorVerticle

Updated ConfigServiceTest

c1fd6df

Removed use of reflection to access private attributes/methods Removed unnecessary tests Updated remaining tests to inject ConfigRetriever into ConfigService

Merge branch 'refs/heads/main' into bmz-UID2-4632-runtime-config-appl…

fc1147a

…ication # Conflicts: # src/main/java/com/uid2/operator/Main.java # src/main/java/com/uid2/operator/service/UIDOperatorService.java

Updated ConfigRetrieverFactory

ab30054

Set http store to optional

Updated ConfigService

7d2a16d

Added default value for max_bidstream_lifetime_seconds

Added ConfigServiceManager, StaticConfigService

67b05b1

ConfigServiceManager handles switching between dynamic and static config StaticConfigService implements IConfigService, serving config from static files

Update UIDOperatorVerticle, Main

25ad265

Main creates new ConfigServiceManager instance and injects it into UIDOperatorVerticle Also Added feature flag config value to local-config.json, Made create method static in ConfigServiceManager

Update UIDOperatorVerticle

6bd4a35

Removed ConfigServiceManager from constructor

Add DelegatingConfigService

80b6b19

Allows for switches between static and dynamic config services without having to change UIDOperatorVerticle

Update ConfigServiceManager, Main

7ef6af6

ConfigRetriever in Main listens for feature flag changes and publishes to eventbus ConfigServiceManager listens to eventbus and updates DelegatingConfigService active ConfigService

Update UIDOperatorVerticleTest

ed3141a

Added tests to verify config changes are reflected in endpoints

Add static config to UIDOperatorVerticle constructor

5cde2b2

static config values are set from main config rather than ConfigService

Update ConfigServiceTest to combine futures using compose

91ecc1d

- removed bootstrap config as a store from ConfigRetrieverFactory

Update feature flag functionality

41e7489

- exclusive config retriever to listen to changes in mounted configmap - listener directly interacts with ConfigServiceManager rather than publishing to EventBus

Add ConfigServiceManager tests

272ac08

Update ConfigServiceTest to remove unnecessary use of mock server

68530b4

Add authorisation header to config retriever

1dfdea3

BehnamMozafari requested a review from abuabraham-ttd January 16, 2025 08:45

BehnamMozafari self-assigned this Jan 16, 2025

BehnamMozafari changed the title ~~Runtime config retrieval and applicatoin~~ Runtime config retrieval and application Jan 17, 2025

BehnamMozafari requested review from sunnywu, jon8787, mcollins-ttd and cYKatherine January 20, 2025 04:41

BehnamMozafari commented Jan 21, 2025

View reviewed changes

scripts/aws/conf/integ-uid2-config.json Outdated Show resolved Hide resolved

BehnamMozafari commented Jan 21, 2025

View reviewed changes

src/main/java/com/uid2/operator/vertx/UIDOperatorVerticle.java Outdated Show resolved Hide resolved

BehnamMozafari commented Jan 21, 2025

View reviewed changes

src/main/java/com/uid2/operator/vertx/UIDOperatorVerticle.java Outdated Show resolved Hide resolved

BehnamMozafari commented Jan 21, 2025

View reviewed changes

src/main/java/com/uid2/operator/Main.java Outdated Show resolved Hide resolved

BehnamMozafari added 2 commits January 21, 2025 15:08

Addressed Review Comments

174b0c1

- Made feature flag json file generic - Small refactoring

Update fallback to static config for running locally

917b0a1

- ConfigRetrieverFactory now creates ConfigRetriever from bootstrap config - Add runtime-config-defaults.json to serve as defaults for running locally

cody-constine-ttd reviewed Jan 22, 2025

View reviewed changes

Address Review Comments:

12fd4b3

- Refactor Const names in Const.Config - Update ConfigValidatorUtil log messages

jon8787 reviewed Jan 24, 2025

View reviewed changes

mcollins-ttd reviewed Jan 29, 2025

View reviewed changes

mcollins-ttd reviewed Jan 30, 2025

View reviewed changes

BehnamMozafari added 9 commits January 31, 2025 14:01

Address Review Comments

d153181

- update config scan period for local-config.json - remove unnecessary config values - make ConfigRetrieverFactory create method static - extract runtime config creation to helper method in Main - Added token config validation to UIDOperatorService

Address Review Comments

45efc32

- fix type inconsistencies - minor code cleanup - replace getConfig() method from BenchmarkCommon with final static fields

Update config files for private operators

8b66537

- Copy feat-flag.json file in dockerfiles - Remove unnecessary config values - Add runtime_config_store config value

Merge main into bmz-UID2-4606-runtime-config-application

ec0207d

Undo run config changes

0a59cb6

Undo run config changes

6f87884

Undo removal of runtime config values from config files

b47557e

Update static config service to use bootstrap config

e1b09e4

Update exception messages in validateTokenDurations method (UIDOperat…

63b0c4b

…orService)

mcollins-ttd approved these changes Feb 3, 2025

View reviewed changes

BehnamMozafari merged commit 418f2bf into main Feb 3, 2025
4 checks passed

BehnamMozafari deleted the bmz-UID2-4606-runtime-config-application branch February 3, 2025 05:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Runtime config retrieval and application #1290

Runtime config retrieval and application #1290

BehnamMozafari commented Jan 16, 2025 •

edited

Loading

Runtime config retrieval and application #1290

Runtime config retrieval and application #1290

Conversation

BehnamMozafari commented Jan 16, 2025 • edited Loading

BehnamMozafari commented Jan 16, 2025 •

edited

Loading