Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a param --server-name to support providing server_name for gradio #949

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

GuangChen2333
Copy link

@GuangChen2333 GuangChen2333 commented Jan 13, 2025

Description

  1. Remove func get_port_from_args()
  2. Add func get_value_from_args() to enhance code reusability.
  3. Add some type annotations to params and returns
  4. Add param --server-name <ip> for gradio

Motivation and Context

Some time we need to run it with ip 0.0.0.0 but now it couldn't do that.

How has this been tested?

I run that on my local server bcz I think it is a tiny change for the code.

Screenshots (if appropriate):

None.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant