Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix korea region #257

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

d3y419
Copy link

@d3y419 d3y419 commented Jan 23, 2025

South Korea was incorrectly categorized in a few models. I went through the list and fixed them.

@d3y419
Copy link
Author

d3y419 commented Jan 23, 2025

@danielhuppmann please review.

@danielhuppmann
Copy link
Member

Thank you - did you reach out to the teams that have the wrong mapping so that they are aware of the info? This might cause difference between legacy projects and newly submitted scenario.

@d3y419
Copy link
Author

d3y419 commented Jan 27, 2025

Thank you - did you reach out to the teams that have the wrong mapping so that they are aware of the info? This might cause difference between legacy projects and newly submitted scenario.

I did not reach out. I could easily check with the GCAM team, but I'm not really sure who to contact for the other teams. More generally, what should be the protocol when national modelers spot errors in their country that the global modelers may not be paying attention to.

@d3y419
Copy link
Author

d3y419 commented Jan 27, 2025

@christophbertram could you review this correction for GCAM?

@d3y419
Copy link
Author

d3y419 commented Jan 27, 2025

@dc-almeida could you review this correction for IMAGE?

@d3y419
Copy link
Author

d3y419 commented Jan 27, 2025

@lbbaptista could you review this correction for COFFEE?

@jkikstra
Copy link
Contributor

@dc-almeida could you review this correction for IMAGE?

probably better for @VassilisDaioglou :)

@lbbaptista
Copy link
Contributor

@lbbaptista could you review this correction for COFFEE?

hey @d3y419, thanks for pointing it out!

@danielhuppmann can you please accept this correction for the COFFEE model?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants