-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix korea region #257
base: main
Are you sure you want to change the base?
Fix korea region #257
Conversation
@danielhuppmann please review. |
Thank you - did you reach out to the teams that have the wrong mapping so that they are aware of the info? This might cause difference between legacy projects and newly submitted scenario. |
I did not reach out. I could easily check with the GCAM team, but I'm not really sure who to contact for the other teams. More generally, what should be the protocol when national modelers spot errors in their country that the global modelers may not be paying attention to. |
@christophbertram could you review this correction for GCAM? |
@dc-almeida could you review this correction for IMAGE? |
@lbbaptista could you review this correction for COFFEE? |
probably better for @VassilisDaioglou :) |
hey @d3y419, thanks for pointing it out! @danielhuppmann can you please accept this correction for the COFFEE model? |
South Korea was incorrectly categorized in a few models. I went through the list and fixed them.