Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Curacao and Sint Maarten #259

Merged
merged 4 commits into from
Jan 27, 2025

Conversation

jkikstra
Copy link
Contributor

@jkikstra jkikstra commented Jan 27, 2025

Add two countries that in 2010, like Aruba in 1986, separated from the Netherlands to become a constituent country inside the Kingdom of the Netherlands

For more, see https://en.wikipedia.org/wiki/Kingdom_of_the_Netherlands

This is a small PR, but points to larger questions (which could be transferred into a new Issue, i think):
(a) when to add new countries to the mapping?
(b) is there a way to ensure that there is no overlap?
(c) is there a way to ensure completeness?
(d) should we force IAM mappings to be up-to-date with the latest common R5/R9/R10 mapping?

How to review?

  • check if this would need to be added somewhere else
  • check if this is in line with the geojson data

…e Netherlands to become a constituent country inside the Kingdom of the Netherlands
@danielhuppmann
Copy link
Member

Looks like we are writing useful error messages to ensure consistency across our projects. ;-)

Copy link
Contributor

@phackstock phackstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@danielhuppmann
Copy link
Member

@lisahligono, would it be a lot of work to re-run the R5/R9/R10 geojsons for the Scenario Explorer map component with the updated country-mapping?

Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@danielhuppmann danielhuppmann merged commit 599e81d into IAMconsortium:main Jan 27, 2025
5 checks passed
@lisahligono
Copy link

@danielhuppmann no it's not a lot of work. I have a working script for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants