-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Curacao and Sint Maarten #259
Add Curacao and Sint Maarten #259
Conversation
…e Netherlands to become a constituent country inside the Kingdom of the Netherlands
Looks like we are writing useful error messages to ensure consistency across our projects. ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@lisahligono, would it be a lot of work to re-run the R5/R9/R10 geojsons for the Scenario Explorer map component with the updated country-mapping? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks
@danielhuppmann no it's not a lot of work. I have a working script for this |
Add two countries that in 2010, like Aruba in 1986, separated from the Netherlands to become a constituent country inside the Kingdom of the Netherlands
For more, see https://en.wikipedia.org/wiki/Kingdom_of_the_Netherlands
This is a small PR, but points to larger questions (which could be transferred into a new Issue, i think):
(a) when to add new countries to the mapping?
(b) is there a way to ensure that there is no overlap?
(c) is there a way to ensure completeness?
(d) should we force IAM mappings to be up-to-date with the latest common R5/R9/R10 mapping?
How to review?