Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a general pytest workflow #92

Merged
merged 5 commits into from
Apr 11, 2024
Merged

Add a general pytest workflow #92

merged 5 commits into from
Apr 11, 2024

Conversation

danielhuppmann
Copy link
Member

No description provided.

@danielhuppmann danielhuppmann self-assigned this Apr 11, 2024
@danielhuppmann
Copy link
Member Author

Thanks @phackstock for noting that the illegal-terms tests wasn't actually running on Github Actions.

Test now failing as expected - and passing again after fixing the intentional violation of the naming conventions.

phackstock
phackstock approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@phackstock phackstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix. Good to merge.

@danielhuppmann danielhuppmann merged commit 0f41e8c into IAMconsortium:main Apr 11, 2024
3 checks passed
@danielhuppmann danielhuppmann deleted the devops/pytest-workflow branch April 11, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phackstock phackstock phackstock approved these changes

Assignees

@danielhuppmann danielhuppmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielhuppmann @phackstock