Common Regions Geojson #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks @deepak-shah-np - just one minor request, can you please rename the readme to README.md, add my clean-up suggestions, and add line breaks after 80 characters.
geojson/readme.md
Outdated
| @@ -0,0 +1,19 @@ | |||
| The initial countries geojson(shapefile) [world_ne](world_ne.geojson) is sourced from the [Natural Earth's official repository, specifically version 5.1.1](https://www.naturalearthdata.com/downloads/50m-cultural-vectors/50m-admin-0-countries-2/). | |||
There was a problem hiding this comment.
Suggested change
| The initial countries geojson(shapefile) [world_ne](world_ne.geojson) is sourced from the [Natural Earth's official repository, specifically version 5.1.1](https://www.naturalearthdata.com/downloads/50m-cultural-vectors/50m-admin-0-countries-2/). | |
| The initial countries geojson (shapefile) [world_ne](world_ne.geojson) is sourced from the [Natural Earth's official repository, version 5.1.1](https://www.naturalearthdata.com/downloads/50m-cultural-vectors/50m-admin-0-countries-2/). |
geojson/readme.md
Outdated
| @@ -0,0 +1,19 @@ | |||
| The initial countries geojson(shapefile) [world_ne](world_ne.geojson) is sourced from the [Natural Earth's official repository, specifically version 5.1.1](https://www.naturalearthdata.com/downloads/50m-cultural-vectors/50m-admin-0-countries-2/). | |||
There was a problem hiding this comment.
Please add a title to the readme
geojson/readme.md
Outdated
|
|
||
| - r5 regions | ||
|
|
||
| OECD & EU (R5), Reforming Economies (R5), Asia (R5),Middle East & Africa (R5),Latin America (R5) |
There was a problem hiding this comment.
Suggested change
| OECD & EU (R5), Reforming Economies (R5), Asia (R5),Middle East & Africa (R5),Latin America (R5) | |
| OECD & EU (R5), Reforming Economies (R5), Asia (R5), Middle East & Africa (R5), Latin America (R5) |
geojson/readme.md
Outdated
|
|
||
| - r9 regions | ||
|
|
||
| European Union (R9), USA (R9), Other OECD (R9), China (R9), India (R9),Other Asia (R9), Reforming Economies (R9), Middle East & Africa (R9), Latin America (R9) |
There was a problem hiding this comment.
Suggested change
| European Union (R9), USA (R9), Other OECD (R9), China (R9), India (R9),Other Asia (R9), Reforming Economies (R9), Middle East & Africa (R9), Latin America (R9) | |
| European Union (R9), USA (R9), Other OECD (R9), China (R9), India (R9), Other Asia (R9), Reforming Economies (R9), Middle East & Africa (R9), Latin America (R9) |
danielhuppmann
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The common regions geojson file is generated from countries geojson(shapefile) which is sourced from the Natural Earth's official repository, specifically version 5.1.1.
The common regions are r5, r9 and r10 which is based on common regions definitions