Add Trade|*|Value variables and fix unit #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orichters
reviewed
May 21, 2024
| definition: value of net exports of Uranium, at the global level these should | ||
| add up to the trade losses only | ||
| unit: billion USD_2010/yr | ||
| - Trade|Emissions Allowances [Value]: |
There was a problem hiding this comment.
Is that also "net exports" by model region?
| @@ -8,3 +8,54 @@ | |||
| unit: billion USD_2010/yr | |||
| tier: 1 | |||
| min: 0 | |||
| - Trade|Primary Energy|Biomass [Value]: | |||
There was a problem hiding this comment.
Are we sure we want to treat "trade losses" like this? That means the summation checks World = Sum(Regions) should be disabled here?
|
As per discussion with @danielhuppmann, I'll close this PR for now and fix the units directly in legacy-definitions. Once we're ready to move the Trade|*|Value variables we can come back to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
Trade|*|Valuevariables over from legcay-definitions and most importantly fixes the units fromEJ/yrtoUSD_2010/yr.FYI @OFR-IIASA