Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NUTS regions #393

Merged
merged 12 commits into from
Sep 20, 2024
Merged

Conversation

dc-almeida
Copy link
Collaborator

Closes #343
@phackstock please confirm if there should be more testing

@dc-almeida dc-almeida added the enhancement New feature or request label Sep 18, 2024
@dc-almeida dc-almeida self-assigned this Sep 18, 2024
Copy link
Contributor

@phackstock phackstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost ready to merge, just a few minor comments below.

nomenclature/__init__.py Outdated Show resolved Hide resolved
nomenclature/codelist.py Outdated Show resolved Hide resolved
nomenclature/config.py Outdated Show resolved Hide resolved
tests/data/general-config-only-nuts/nomenclature.yaml Outdated Show resolved Hide resolved
nomenclature/config.py Outdated Show resolved Hide resolved
nomenclature/codelist.py Outdated Show resolved Hide resolved
Copy link
Contributor

@phackstock phackstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work @dc-almeida, good to be merged.

@dc-almeida dc-almeida merged commit 4ae6fa3 into IAMconsortium:main Sep 20, 2024
11 checks passed
@dc-almeida dc-almeida deleted the feature/pysquirrel branch October 29, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add NUTS regions as an option
2 participants