Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter mappings from external repo #460

Merged
merged 8 commits into from
Jan 16, 2025
Merged

Filter mappings from external repo #460

merged 8 commits into from
Jan 16, 2025

Conversation

phackstock
Copy link
Contributor

Closes #457.

This PR extends the filter feature to model mappings using the following syntax:

repositories:
  common-definitions:
    url: https://github.com/IAMconsortium/common-definitions.git/
mappings:
  repository:
    name: common-definitions
    include:
      - MESSAGEix-GLOBIOM 2.1-M-R12

@phackstock phackstock self-assigned this Jan 15, 2025
danielhuppmann
danielhuppmann approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Two nitpicky suggestions inline, but good to be merged from my side

docs/user_guide/config.rst Outdated Show resolved Hide resolved
tests/data/region_processing/external_repo_test/nomenclature.yaml Outdated Show resolved Hide resolved
tests/test_region_aggregation.py Outdated Show resolved Hide resolved
@phackstock
Copy link
Contributor Author

Two nitpicky suggestions inline, but good to be merged from my side

That's why we do the reviews 😄

@phackstock phackstock merged commit 941fc73 into IAMconsortium:main Jan 16, 2025
11 checks passed
@phackstock phackstock deleted the feature/filter-mappings-from-external-repo branch January 16, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielhuppmann danielhuppmann danielhuppmann approved these changes

@dc-almeida dc-almeida Awaiting requested review from dc-almeida

Assignees

@phackstock phackstock

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow filtering of model mappings from external repositories
2 participants
@phackstock @danielhuppmann