Remove None defaults from RegionAggregationMapping #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dc-almeida
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Thanks! Once merged, I will rebase and refactor my code in #463 to reflect the change.
dc-almeida
pushed a commit
to dc-almeida/nomenclature
that referenced
this pull request
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #465.
This PR removes the
Nonedefaults fornative_regions,common_regionsandexclude_regionsand replaces it with empty lists.This allows us to get rid of some if guards that we had before attempting to iterate over the above lists. As a result,
_apply_region_processingis now less nested and easier to read.In addition I also cleaned up
RegionAggregationMappinga bit making use of some more pydantic native features. The two clean ups are:model_config = ConfigDict(extra="forbid")to prevent additional attributes instead of checking explicitlyto_yamlto use serializers for more complex fields.