Validate timeseries data using explicit value and rtol
#866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #866 +/- ##
=======================================
- Coverage 95.0% 94.9% -0.1%
=======================================
Files 64 63 -1
Lines 6134 6164 +30
=======================================
+ Hits 5828 5855 +27
- Misses 306 309 +3 ☔ View full report in Codecov by Sentry. |
|
After some thoughts, I concluded that implementing this feature in nomenclature makes more sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please confirm that this PR has done the following:
Name of contributors Added to AUTHORS.rstDescription of PR
This PR adds keyword arguments to
validate()to use value and rtol directly instead of upper_bound and lower_bound, in response to the discussion in IAMconsortium/common-definitions#104. However, now that I've implemented this, I'm wondering whether it wouldn't make more sense to keep the pyam method lean and do the translation from value and rtol as part of a nomenclature.DataValidator class...Any thoughts @phackstock?