Skip to content

Commit

Permalink
Merge pull request #943 from revit13/minorfix13
Browse files Browse the repository at this point in the history
Remove KFP_DOCKER_VERSION.
  • Loading branch information
touma-I authored Jan 16, 2025
2 parents c529599 + f7d3932 commit 65beee8
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 8 deletions.
3 changes: 0 additions & 3 deletions .make.versions
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,6 @@ DPK_LIB_KFP_VERSION=$(DPK_VERSION)
DPK_LIB_KFP_VERSION_v2=$(DPK_VERSION)
DPK_LIB_KFP_SHARED=$(DPK_VERSION)

KFP_DOCKER_VERSION=$(DOCKER_IMAGE_VERSION)
KFP_DOCKER_VERSION_v2=$(DOCKER_IMAGE_VERSION)

DPK_CONNECTOR_VERSION=0.2.4.dev0

################## ################## ################## ################## ################## ##################
Expand Down
2 changes: 0 additions & 2 deletions kfp/RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ The KFP package build uses the following variables from the file:
- DPK_LIB_KFP_VERSION - the version of `kfp_v1_workflow_support`
- DPK_LIB_KFP_VERSION_v2 - the version of `kfp_v2_workflow_support`
- DPK_LIB_KFP_SHARED - the version of `kfp_shared_workflow_support`
- KFP_DOCKER_VERSION - the docker image version of KFP components for KFPv1
- KFP_DOCKER_VERSION_v2 - the docker image version of KFP components for KFPv2

**Note:** The docker images are dependent on the libraries but use the python source code from the repository, so inorder
to build docker images, the python modules (libraries) do not have to be deployed.
Expand Down
6 changes: 3 additions & 3 deletions kfp/kfp_ray_components/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ image: Dockerfile requirements.txt

.PHONE: set-versions
set-versions:
@# Help: Update yaml files to build images tagged as version $(KFP_DOCKER_VERSION).
@# Help: Update yaml files to build images tagged as version $(DOCKER_IMAGE_VERSION).
@$(MAKE) .reconcile-requirements FILE=createRayClusterComponent.yaml
@$(MAKE) .reconcile-requirements FILE=deleteRayClusterComponent.yaml
@$(MAKE) .reconcile-requirements FILE=executeRayJobComponent.yaml
Expand All @@ -71,9 +71,9 @@ docker-save-image:
.PHONY: publish
publish:
echo "Publishing kfp-data-processing"
$(MAKE) KFPv2=0 DOCKER_IMAGE_NAME="kfp-data-processing" DOCKER_IMAGE_VERSION=${KFP_DOCKER_VERSION} .defaults.publish-image
$(MAKE) KFPv2=0 DOCKER_IMAGE_NAME="kfp-data-processing" .defaults.publish-image
echo "Publishing kfp-data-processing_v2"
$(MAKE) KFPv2=1 DOCKER_IMAGE_NAME="kfp-data-processing_v2" DOCKER_IMAGE_VERSION=${KFP_DOCKER_VERSION_v2} .defaults.publish-image
$(MAKE) KFPv2=1 DOCKER_IMAGE_NAME="kfp-data-processing_v2" .defaults.publish-image

test::

Expand Down

0 comments on commit 65beee8

Please sign in to comment.