Install the SPARQLProg package system-wide. #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When installing the SPARQLProg package using SWIPL, make sure the package is installed in a system-wide directory (under /usr/local) rather than the home directory of the running user (root). Otherwise only root would be able to use the package. closes #1134
gouttegd
added a commit
that referenced
this pull request
Nov 22, 2024
When installing the SPARQLProg package using SWIPL, make sure the package is installed in a system-wide directory (under /usr/local) rather than the home directory of the running user (root). Otherwise only root would be able to use the package.
matentzn
reviewed
Nov 22, 2024
| @@ -4,7 +4,7 @@ ARG ODKLITE_TAG=latest | |||
| FROM obolibrary/odklite:${ODKLITE_TAG} | |||
| LABEL maintainer="[email protected]" | |||
|
|
|||
| ENV PATH="/tools/apache-jena/bin:/tools/sparqlprog/bin:$PATH" | |||
| ENV PATH "/tools/apache-jena/bin:/usr/local/share/swi-prolog/pack/sparqlprog/bin:$PATH" | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Doh!
So what probably happened is that I started fixing this issue while I was on the 1.5 maintenance branch (where your fix for the ENV declaration is not present), and then when I realized that I switched over to the master branch -- and in the process, I ported back to the master branch the old ENV declaration.
My bad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing the SPARQLProg package using SWIPL, we must install make sure that the package is installed in a system-wide directory (under /usr/local) rather than the home directory of the running user (root). Otherwise only root would be able to use the package.
This PR does that by setting the
globaloption totruewhen calling SWIPL’spack_installfunction. Then we update the running PATH to include the/usr/local/share/swi-prolog/pack/sparqlprog/bindirectory. And we add SPARQLProg’spl2sparqlprogram to the list of programs to check after a build.closes #1134