Add new Makefile variable REASONER. #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of hard-coding `{{ project.reasoner }}` at several places in the
standard Makefile (whenever a reasoner is required), we add a new Make
variable REASONER which is set to the value of `{{ project.reasoner }}`,
and which is then used whenever a reasoner is required.
This allows:
(1) quickly changing the reasoner used by an entire project, without
having to change the ODK configuration and re-generate the Makefile
(e.g. for temporarily testing another reasoner);
(2) custom worklows in $(ONT).Makefile to automatically use the same
reasoner as the standard workflows, by using the REASONER variable
themselves instead of hard-coding a reasoner's name.
closes #1139
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hard-coding
{{ project.reasoner }}at several places in the standard Makefile (whenever a reasoner is required), we add a new Make variable REASONER which is set to the value of{{ project.reasoner }}, and which is then used whenever a reasoner is required.This allows:
(1) quickly changing the reasoner used by an entire project, without having to change the ODK configuration and re-generate the Makefile (e.g. for temporarily testing another reasoner);
(2) custom worklows in $(ONT).Makefile to automatically use the same reasoner as the standard workflows, by using the REASONER variable themselves instead of hard-coding a reasoner's name.
closes #1139